Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 9147052: fix panel window string resource ID (Closed)

Created:
8 years, 11 months ago by Evan Stade
Modified:
8 years, 11 months ago
CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng, prasadt
Visibility:
Public.

Description

fix panel window string resource ID The panel window code was using IDS_NEW_TAB_APP_SETTINGS even though it had nothing to do with the new tab. The NEW_TAB_APP_SETTINGS string is no longer used for its original purpose, so I have deleted it, and replaced it with a new string specifically for the panel window wrench button use case. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117319

Patch Set 1 #

Total comments: 2

Patch Set 2 : better string desc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M chrome/app/generated_resources.grd View 1 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/browser_titlebar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_frame_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Evan Stade
8 years, 11 months ago (2012-01-11 00:47:52 UTC) #1
Evan Stade
+erg
8 years, 11 months ago (2012-01-11 00:54:51 UTC) #2
prasadt
lgtm http://codereview.chromium.org/9147052/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/9147052/diff/1/chrome/app/generated_resources.grd#newcode14804 chrome/app/generated_resources.grd:14804: desc="Text for the tooltip on panel window wrench ...
8 years, 11 months ago (2012-01-11 00:58:59 UTC) #3
Evan Stade
http://codereview.chromium.org/9147052/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/9147052/diff/1/chrome/app/generated_resources.grd#newcode14804 chrome/app/generated_resources.grd:14804: desc="Text for the tooltip on panel window wrench buttons."> ...
8 years, 11 months ago (2012-01-11 03:26:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/9147052/5001
8 years, 11 months ago (2012-01-11 03:27:35 UTC) #5
commit-bot: I haz the power
Try job failure for 9147052-5001 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 11 months ago (2012-01-11 04:06:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/9147052/5001
8 years, 11 months ago (2012-01-11 04:17:29 UTC) #7
commit-bot: I haz the power
Try job failure for 9147052-5001 (retry) (retry) on win_rel for step "svnkill". It's a second ...
8 years, 11 months ago (2012-01-11 05:57:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/9147052/5001
8 years, 11 months ago (2012-01-11 21:59:19 UTC) #9
commit-bot: I haz the power
8 years, 11 months ago (2012-01-11 23:10:49 UTC) #10
Change committed as 117319

Powered by Google App Engine
This is Rietveld 408576698