content/browser/site_instance.h - Issue 9147051: Don't swap processes for javascript: URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/site_instance.h

Issue 9147051: Don't swap processes for javascript: URLs. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fixed the unit test and restored the function to not be virtual. Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/site_instance.h

diff --git a/content/browser/site_instance.h b/content/browser/site_instance.h

index b85aa9ad4050882b08171fa53bac56497430bedc..42ab12c375f0870ec998ad5622b22f0a8f89ee51 100644

--- a/content/browser/site_instance.h

+++ b/content/browser/site_instance.h

@@ -74,6 +74,7 @@ class CONTENT_EXPORT SiteInstance : public base::RefCounted<SiteInstance>,

}

// Whether this SiteInstance has a running process associated with it.

+ // Virtual to allow tests to extend it.

Charlie Reis 2012/01/13 18:37:46 No longer need this comment.

nasko 2012/01/13 20:54:49 Done.

bool HasProcess() const;

// Returns the current process being used to render pages in this