Don't swap processes for javascript: URLs.

content/browser/site_instance_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/compiler_specific.h"
 #include "base/stl_util.h"
 #include "base/string16.h"
 #include "content/browser/browser_thread_impl.h"
 #include "content/browser/browsing_instance.h"
 #include "content/browser/child_process_security_policy.h"
@@ skipping 133 matching lines @@
  public:
   static TestSiteInstance* CreateTestSiteInstance(
       content::BrowserContext* browser_context,
       int* siteDeleteCounter,
       int* browsingDeleteCounter) {
     TestBrowsingInstance* browsing_instance =
         new TestBrowsingInstance(browser_context, browsingDeleteCounter);
     return new TestSiteInstance(browsing_instance, siteDeleteCounter);
   }
 
+  bool HasProcess() const OVERRIDE {
+    return hasProcess;
+  }
+
+  bool hasProcess;

[awong, 2012/01/12 22:56:41]

incorrect naming convention. :(

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Variable_Names

Also, a setter is preferable to a public variable even if this is a file private
class.

[nasko, 2012/01/13 01:34:50]

Moved to a different test that doesn't require modifying this test class. Still
fixed up the class to be more inline with the style guide.

+
  private:
   TestSiteInstance(BrowsingInstance* browsing_instance, int* deleteCounter)
     : SiteInstance(browsing_instance), deleteCounter_(deleteCounter) {}
   ~TestSiteInstance() {

[awong, 2012/01/12 22:56:41]

Since we're here, can we add a virtual in front of this?

[nasko, 2012/01/13 01:34:50]

Done.

     (*deleteCounter_)++;
   }
 
   int* deleteCounter_;
 };
 
 }  // namespace
 
 // Test to ensure no memory leaks for SiteInstance objects.
 TEST_F(SiteInstanceTest, SiteInstanceDestructor) {
@@ skipping 371 matching lines @@
   // Make sure none of differing privilege processes are mixed.
   EXPECT_NE(extension1_instance->GetProcess(), webui1_instance->GetProcess());
 
   for (size_t i = 0; i < content::kMaxRendererProcessCount; ++i) {
     EXPECT_NE(extension1_instance->GetProcess(), hosts[i]);
     EXPECT_NE(webui1_instance->GetProcess(), hosts[i]);
   }
 
   STLDeleteContainerPointers(hosts.begin(), hosts.end());
 }
+
+// Test to ensure that javascript URLs always run in the same process.
+TEST_F(SiteInstanceTest, HasWrongProcessForURL) {
+
+  int siteDeleteCounter = 0;
+  int browsingDeleteCounter = 0;
+  const GURL url_javascript = GURL("javascript:alert(document.location.href);");
+  const GURL goog = GURL("http://google.com");
+
+  TestSiteInstance* instance = TestSiteInstance::CreateTestSiteInstance(

[awong, 2012/01/12 22:56:41]

Line indent on wrapping should be 4 spaces.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Function_Calls

[nasko, 2012/01/13 01:34:50]

Done.

+                                  NULL, &siteDeleteCounter,
+                                  &browsingDeleteCounter);
+
+  EXPECT_FALSE(instance->has_site());
+  EXPECT_TRUE(instance->site().is_empty());
+
+  instance->SetSite(GURL("http://www.evernote.com/"));
+  EXPECT_TRUE(instance->has_site());
+
+  // Check prior to "assigning" a process to the instance, which is expected
+  // to return false due to not being attached to any process yet.
+  EXPECT_FALSE(instance->HasWrongProcessForURL(goog));
+
+  instance->hasProcess = true;
+  EXPECT_TRUE(instance->HasProcess());
+
+  EXPECT_FALSE(instance->HasWrongProcessForURL(url_javascript));
+}