Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 9147044: GTK: More GSEALing. (Closed)

Created:
8 years, 11 months ago by Elliot Glaysher
Modified:
8 years, 11 months ago
Reviewers:
jam, James Hawkins, sky
CC:
chromium-reviews, asanka, Avi (use Gerrit), creis+watch_chromium.org, brettw-cc_chromium.org, jam, Randy Smith (Not in Mondays), dcheng, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, James Su
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

GTK: More GSEALing. BUG=79722 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117267

Patch Set 1 #

Patch Set 2 : gtk compat fix #

Total comments: 1

Patch Set 3 : jhawkins refactor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -52 lines) Patch
M chrome/browser/tab_contents/chrome_tab_contents_view_wrapper_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/about_chrome_dialog.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_utils_gtk.cc View 1 2 3 chunks +23 lines, -18 lines 0 comments Download
M chrome/browser/ui/gtk/bubble/bubble_gtk.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/chrome_gtk_frame.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/custom_button.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/download/download_shelf_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/fullscreen_exit_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_chrome_shrinkable_hbox.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_custom_menu.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_custom_menu_item.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_util.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/nine_box.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/web_drag_dest_gtk.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M ui/base/gtk/gtk_compat.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Elliot Glaysher
jhawkins: gtk sky: ui stamp jam: content stamp (hopefully the last one for this)
8 years, 11 months ago (2012-01-10 22:22:47 UTC) #1
Elliot Glaysher
On 2012/01/10 22:22:47, Elliot Glaysher wrote: > jhawkins: gtk > sky: ui stamp > jam: ...
8 years, 11 months ago (2012-01-10 22:23:17 UTC) #2
James Hawkins
LGTM with refactoring nit. http://codereview.chromium.org/9147044/diff/1018/chrome/browser/ui/gtk/bookmarks/bookmark_utils_gtk.cc File chrome/browser/ui/gtk/bookmarks/bookmark_utils_gtk.cc (right): http://codereview.chromium.org/9147044/diff/1018/chrome/browser/ui/gtk/bookmarks/bookmark_utils_gtk.cc#newcode398 chrome/browser/ui/gtk/bookmarks/bookmark_utils_gtk.cc:398: if (selection_data && gtk_selection_data_get_length(selection_data) > ...
8 years, 11 months ago (2012-01-10 22:26:25 UTC) #3
sky
LGTM
8 years, 11 months ago (2012-01-10 23:20:03 UTC) #4
jam
content lgtm (btw scott is also an owner for content\browser)
8 years, 11 months ago (2012-01-11 01:40:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9147044/3004
8 years, 11 months ago (2012-01-11 18:22:00 UTC) #6
commit-bot: I haz the power
8 years, 11 months ago (2012-01-11 20:03:29 UTC) #7
Change committed as 117267

Powered by Google App Engine
This is Rietveld 408576698