Change cloud print dialog style in Aura

Change cloud print dialog style in Aura builds.
This style more closely resembles other print dialogs and adds a close button.

BUG=109283, 109084
TEST=Verify bugs.  Make sure dialogs can be closed.  Choosing "Sign-in" from the print preview UI in Chrome OS is NOT yet fixed.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117272

[Scott Byer, 2012-01-11 00:18:40]

lgtm

[commit-bot: I haz the power, 2012-01-11 17:13:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abodenha@chromium.org/9147040/1005

[commit-bot: I haz the power, 2012-01-11 17:13:54]

Presubmit check for 9147040-1005 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/ui/webui/cloud_print_signin_dialog.cc

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[Albert Bodenhamer, 2012-01-11 17:21:38]

+jhawkins for OWNERS review

[James Hawkins, 2012-01-11 17:25:54]

http://codereview.chromium.org/9147040/diff/1005/chrome/browser/printing/prin...
File chrome/browser/printing/print_dialog_cloud.cc (right):

http://codereview.chromium.org/9147040/diff/1005/chrome/browser/printing/prin...
chrome/browser/printing/print_dialog_cloud.cc:24: #if defined(USE_AURA)
OS-specific includes go after the cross-platform includes.

http://codereview.chromium.org/9147040/diff/1005/chrome/browser/printing/prin...
chrome/browser/printing/print_dialog_cloud.cc:612: const int kDefaultWidth =
912;
What is this change about?

http://codereview.chromium.org/9147040/diff/1005/chrome/browser/ui/webui/clou...
File chrome/browser/ui/webui/cloud_print_signin_dialog.cc (right):

http://codereview.chromium.org/9147040/diff/1005/chrome/browser/ui/webui/clou...
chrome/browser/ui/webui/cloud_print_signin_dialog.cc:167: 912,
Move these into constants, but more likely refactor this value and the
previously commented-on value into a common variable.

http://codereview.chromium.org/9147040/diff/1005/chrome/browser/ui/webui/clou...
chrome/browser/ui/webui/cloud_print_signin_dialog.cc:211: HtmlDialogView*
html_view =
This is the same code as the last file, no?  Needs to be refactored.

[Albert Bodenhamer, 2012-01-11 18:11:44]

cloud_print_signin_dialog.cc really should go away entirely.  Rather than go to
the effort of significant cleanup on something I'm going to kill anyway I'll
just kill it sooner.

I've reverted the changes for cloud_print_signin_dialog.cc.  I'll tackle that in
another CL.

http://codereview.chromium.org/9147040/diff/1005/chrome/browser/printing/prin...
File chrome/browser/printing/print_dialog_cloud.cc (right):

http://codereview.chromium.org/9147040/diff/1005/chrome/browser/printing/prin...
chrome/browser/printing/print_dialog_cloud.cc:24: #if defined(USE_AURA)
On 2012/01/11 17:25:54, James Hawkins wrote:
> OS-specific includes go after the cross-platform includes.

Done.

http://codereview.chromium.org/9147040/diff/1005/chrome/browser/printing/prin...
chrome/browser/printing/print_dialog_cloud.cc:612: const int kDefaultWidth =
912;
On 2012/01/11 17:25:54, James Hawkins wrote:
> What is this change about?
The sign-in dialog has gotten much larger since these values were initially set.
 Since I was changing the dialog style I addressed the size issue at the same
time.

In retrospect it should be a separate change, so I've reverted it.

[James Hawkins, 2012-01-11 18:13:34]

LGTM

[commit-bot: I haz the power, 2012-01-11 18:17:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abodenha@chromium.org/9147040/10003

[commit-bot: I haz the power, 2012-01-11 20:13:25]

Change committed as 117272