Issue 9147034: Inlining Math.min and Math.max in crankshaft.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+175 lines, -5 lines)			Patch
M	src/arm/lithium-codegen-arm.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 2 3 4	3 chunks	+10 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1 2 3 4	1 chunk	+51 lines, -0 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1 2 3 4	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 2 3 4	3 chunks	+21 lines, -1 line	0 comments	Download
M	src/ia32/lithium-ia32.h	View	1 2 3 4	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 2 3 4	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/objects.h	View	1 2 3 4	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 2 3 4	3 chunks	+11 lines, -0 lines	0 comments	Download
M	test/mjsunit/math-min-max.js	View	1 2 3	1 chunk	+64 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

This is a first draft. Some parts have to be ported to other platforms before ...

8 years, 11 months ago (2012-01-10 16:27:03 UTC) #1

fschneider

Approach looks good. I have only a few small comments for now. http://codereview.chromium.org/9147034/diff/5001/src/hydrogen.cc File src/hydrogen.cc ...

8 years, 11 months ago (2012-01-11 10:29:32 UTC) #2

Yang

Addressed issues and ported to x64 and arm. Please take another look.

8 years, 11 months ago (2012-01-11 12:26:14 UTC) #3

LGTM.

Expand Messages | Collapse Messages