Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2756)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/url_request/url_request_throttler_unittest.cc

Issue 9147026: API for connection type (Ethernet/WIFI/WWAN ...) in NetworkChangeNotifier. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: sync Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/socket/tcp_client_socket_win.cc ('K') | « net/url_request/url_request_throttler_manager.cc ('k') | remoting/host/signaling_connector.h » ('j') | remoting/host/signaling_connector.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_throttler_unittest.cc
diff --git a/net/url_request/url_request_throttler_unittest.cc b/net/url_request/url_request_throttler_unittest.cc
index 11a1f76e9f6842fd856ac712190bb030284b6419..ee6315d1d9b06b16aeede93e39e61c98f62ed3af 100644
--- a/net/url_request/url_request_throttler_unittest.cc
+++ b/net/url_request/url_request_throttler_unittest.cc
@@ -511,10 +511,12 @@ TEST(URLRequestThrottlerManager, ClearOnNetworkChange) {
manager.OnIPAddressChanged();
break;
case 1:
- manager.OnOnlineStateChanged(true);
+ manager.OnConnectionTypeChanged(
+ net::NetworkChangeNotifier::CONNECTION_ETHERNET);
wtc 2012/05/11 01:35:05 Nit: CONNECTION_UNKNOWN seems better than CONNECTI
break;
case 2:
- manager.OnOnlineStateChanged(false);
+ manager.OnConnectionTypeChanged(
+ net::NetworkChangeNotifier::CONNECTION_NONE);
break;
default:
FAIL();
« net/socket/tcp_client_socket_win.cc ('K') | « net/url_request/url_request_throttler_manager.cc ('k') | remoting/host/signaling_connector.h » ('j') | remoting/host/signaling_connector.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698