net/base/network_change_notifier_win_unittest.cc - Issue 9147026: API for connection type (Ethernet/WIFI/WWAN ...) in NetworkChangeNotifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/network_change_notifier_win_unittest.cc

Issue 9147026: API for connection type (Ethernet/WIFI/WWAN ...) in NetworkChangeNotifier. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: sync Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/base/network_change_notifier_win.cc ('K') | « net/base/network_change_notifier_win.cc ('k') | net/socket/tcp_client_socket_libevent.cc » ('j') | net/socket/tcp_client_socket_libevent.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/base/network_change_notifier_win_unittest.cc

diff --git a/net/base/network_change_notifier_win_unittest.cc b/net/base/network_change_notifier_win_unittest.cc

index 170755ae00b0a302458fc9c2c28623b869c7cecc..216359e7f3e05b4ea3527b31fb9d15333bccbada 100644

--- a/net/base/network_change_notifier_win_unittest.cc

+++ b/net/base/network_change_notifier_win_unittest.cc

@@ -31,8 +31,9 @@ class TestNetworkChangeNotifierWin : public NetworkChangeNotifierWin {

}

// From NetworkChangeNotifier.

- virtual bool IsCurrentlyOffline() const OVERRIDE {

- return false;

+ virtual NetworkChangeNotifier::ConnectionType

+ GetCurrentConnectionType() const OVERRIDE {

+ return NetworkChangeNotifier::CONNECTION_ETHERNET;;

wtc 2012/05/11 01:35:05 Nit: CONNECTION_UNKNOWN seems better than CONNECTI

}

// From NetworkChangeNotifierWin.