chrome/browser/net/network_stats.cc - Issue 9147026: API for connection type (Ethernet/WIFI/WWAN ...) in NetworkChangeNotifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/network_stats.cc

Issue 9147026: API for connection type (Ethernet/WIFI/WWAN ...) in NetworkChangeNotifier. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: sync Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/login_utils.cc ('K') | « chrome/browser/chromeos/web_socket_proxy_controller.cc ('k') | chrome/browser/renderer_host/offline_resource_throttle.cc » ('j') | chrome/browser/renderer_host/offline_resource_throttle.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/network_stats.cc

diff --git a/chrome/browser/net/network_stats.cc b/chrome/browser/net/network_stats.cc

index 64023a4c3d708b0ff67635680c89dda12d6d6029..1283d6791a2e68ddb44ea13c17d230f8a653c9b1 100644

--- a/chrome/browser/net/network_stats.cc

+++ b/chrome/browser/net/network_stats.cc

@@ -804,7 +804,8 @@ void CollectNetworkStats(const std::string& network_stats_server,

// Check that there is a network connection. We get called only if UMA upload

// to the server has succeeded.

- DCHECK(!net::NetworkChangeNotifier::IsOffline());

+ DCHECK(net::NetworkChangeNotifier::GetConnectionType() !=

wtc 2012/05/11 01:35:05 Nit: use DCHECK_NE

+ net::NetworkChangeNotifier::CONNECTION_NONE);

CR_DEFINE_STATIC_LOCAL(scoped_refptr<base::FieldTrial>, trial, ());

static bool collect_stats = false;