net/base/network_change_notifier_win.h - Issue 9147026: API for connection type (Ethernet/WIFI/WWAN ...) in NetworkChangeNotifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/network_change_notifier_win.h

Issue 9147026: API for connection type (Ethernet/WIFI/WWAN ...) in NetworkChangeNotifier. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Review comments Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/network_change_notifier_win.h

diff --git a/net/base/network_change_notifier_win.h b/net/base/network_change_notifier_win.h

index aee5304ff6fe3d03506fa9827f99f55a1b16c14b..6d1106bff99de25724026cb2ce12ef448960629d 100644

--- a/net/base/network_change_notifier_win.h

+++ b/net/base/network_change_notifier_win.h

@@ -50,7 +50,7 @@ class NET_EXPORT_PRIVATE NetworkChangeNotifierWin

friend class NetworkChangeNotifierWinTest;

// NetworkChangeNotifier methods:

- virtual bool IsCurrentlyOffline() const OVERRIDE;

+ virtual ConnectionType GetCurrentConnectionType() const OVERRIDE;

// ObjectWatcher::Delegate methods:

// Must only be called on the thread |this| was created on.

@@ -62,7 +62,7 @@ class NET_EXPORT_PRIVATE NetworkChangeNotifierWin

void NotifyObservers();

// Forwards online state notifications to parent class.

wtc 2012/05/11 18:46:22 online state => network connection type

- void NotifyParentOfOnlineStateChange();

+ void NotifyParentOfConnectionTypeChange();

// Tries to start listening for a single subsequent address change. Returns

// false on failure. The caller is responsible for updating |is_watching_|.

« net/base/network_change_notifier_mac.h ('K') | « net/base/network_change_notifier_mac.cc ('k') | net/base/network_change_notifier_win.cc » ('j') | no next file with comments »