Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 9147017: Teach webkit/support/setup_third_party.gyp about the Platform API (Closed)

Created:
8 years, 11 months ago by jamesr
Modified:
8 years, 11 months ago
Reviewers:
tony
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Teach webkit/support/setup_third_party.gyp about the Platform API In a chromium-inside-WebKit checkout, there is no third_party/WebKit directory but files inside chromium's webkit/ tree have absolute include paths. This is resolved by a script that copies the header into the output dir in the expected path. This updates the script to know about the Platform API header locations. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116989

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M webkit/support/setup_third_party.gyp View 3 chunks +25 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jamesr
Seems to work locally.
8 years, 11 months ago (2012-01-09 23:41:34 UTC) #1
tony
LGTM. When rolling it into WebKit, watch the win bot on build.webkit.org. We've had problems ...
8 years, 11 months ago (2012-01-09 23:47:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/9147017/1
8 years, 11 months ago (2012-01-10 00:10:59 UTC) #3
commit-bot: I haz the power
8 years, 11 months ago (2012-01-10 02:33:59 UTC) #4
Change committed as 116989

Powered by Google App Engine
This is Rietveld 408576698