fix issue 356 by making test match spec

fix issue 356 by making test match spec

Committed: https://code.google.com/p/dart/source/detail?r=3234

[gbracha, 2012-01-09 21:37:39]

http://codereview.chromium.org/9147006/diff/3001/tests/language/src/PseudoKWC...
File tests/language/src/PseudoKWClassTest.dart (right):

http://codereview.chromium.org/9147006/diff/3001/tests/language/src/PseudoKWC...
tests/language/src/PseudoKWClassTest.dart:5: 
I'm sorry, but the spec on this is actually going to change, so that the old
test will be valid, and the new one won't. That is, built-in identifiers as
types will be disallowed.

[jimhug, 2012-01-09 22:17:39]

PTAL

Based on Gilad's feedback, I moved this back to a negative test, but I also
expanded the coverage to all builtin identifiers in the hopes of trying to make
the expected behavior clear.

[jimhug, 2012-01-10 17:43:30]

Any more comments?  Is this ready to submit?

[jimhug, 2012-01-11 17:46:11]

On 2012/01/10 17:43:30, jimhug wrote:
> Any more comments?  Is this ready to submit?

Gilad - I'd like to get your explicit LGTM on this test as capturing the correct
set of builtin identifiers/pseudo-keywords.  Can you please either give me that
or point me to a different list to use?

BTW - This list was copied from the one in PseudoKeywordTest.dart and if any
changes are required here then then test probably needs to be changed as well.

[gbracha, 2012-01-11 19:27:01]

http://codereview.chromium.org/9147006/diff/6001/tests/language/src/PseudoKWN...
File tests/language/src/PseudoKWNegativeTest.dart (right):

http://codereview.chromium.org/9147006/diff/6001/tests/language/src/PseudoKWN...
tests/language/src/PseudoKWNegativeTest.dart:19: class static { }      /// 13:
compile-time error
Below is the latest list of built-in identifiers from the spec. You will note
that you are missing assert, call (that is brand-new due to function emulation
and not a high priority yet), Dynamic and typedef. Also, native is not a
built-in identifier. It's a per-implementation extension, but it is not part of
the language. 

BUILT_IN_IDENTIFIER:
      abstract
    | assert
    | call
    | Dynamic
    | factory
    | get
    | implements
    | import
    | interface
    | library
    | negate
    | operator
    | set
    | source
    | static
    | typedef

[jimhug, 2012-01-11 23:11:10]

PTAL

I think I've got the correct list of built-in identifiers in both the positive
and negative tests now.  I think I've also finally come up with a version that
will run in both test.py and test.dart - so we don't hit any weird issues during
the next week or so of integration.

Gilad - I don't expect you to review this for test infrastructure correctness. 
If I screwed up something there I'm on the hook and will be watching this
carefully.  I just want your LGTM on the important issue of whether or not these
two test cases now consistently capture the correct language semantics.

[gbracha, 2012-01-11 23:23:17]

LGTM.  One could extend this to test that typedefs, interfaces and type
variables using these ids are illegal, and other things are legal. But the list
is correct.