Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 9147003: exclude platform_data_fetcher_linux.cc on *BSD because of udev specific code (Closed)

Created:
8 years, 11 months ago by Robert Nagy
Modified:
8 years, 11 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Exclude platform_data_fetcher_linux.cc on *BSD because of udev specific code Also disable libudev on *BSD because it's not available. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116868

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/linux/system.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Nagy
Hi Mark, Happy new year! Can you please review this? Thanks
8 years, 11 months ago (2012-01-09 12:41:51 UTC) #1
Mark Mentovai
LGTM and CQ
8 years, 11 months ago (2012-01-09 14:26:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robert.nagy@gmail.com/9147003/1
8 years, 11 months ago (2012-01-09 14:26:40 UTC) #3
commit-bot: I haz the power
8 years, 11 months ago (2012-01-09 16:27:06 UTC) #4
Change committed as 116868

Powered by Google App Engine
This is Rietveld 408576698