Define the public interface for content browser SiteInstance. This interface is implemented by th...

content/browser/browsing_instance.cc

Index: content/browser/browsing_instance.cc
===================================================================
--- content/browser/browsing_instance.cc	(revision 118703)
+++ content/browser/browsing_instance.cc	(working copy)
@@ -6,7 +6,7 @@
 
 #include "base/command_line.h"
 #include "base/logging.h"
-#include "content/browser/site_instance.h"
+#include "content/browser/site_instance_impl.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/web_ui_factory.h"
@@ -56,8 +56,8 @@
 
 BrowsingInstance::SiteInstanceMap* BrowsingInstance::GetSiteInstanceMap(
     content::BrowserContext* browser_context, const GURL& url) {
-  if (!ShouldUseProcessPerSite(SiteInstance::GetEffectiveURL(browser_context,
-                                                             url))) {
+  if (!ShouldUseProcessPerSite(
+      content::SiteInstance::GetEffectiveURL(browser_context, url))) {
     // Not using process-per-site, so use a map specific to this instance.
     return &site_instance_map_;
   }
@@ -69,7 +69,7 @@
 
 bool BrowsingInstance::HasSiteInstance(const GURL& url) {
   std::string site =
-      SiteInstance::GetSiteForURL(browser_context_, url)
+      content::SiteInstance::GetSiteForURL(browser_context_, url)
           .possibly_invalid_spec();
 
   SiteInstanceMap* map = GetSiteInstanceMap(browser_context_, url);
@@ -77,9 +77,10 @@
   return (i != map->end());
 }
 
-SiteInstance* BrowsingInstance::GetSiteInstanceForURL(const GURL& url) {
+content::SiteInstance* BrowsingInstance::GetSiteInstanceForURL(

[jam, 2012/01/24 03:29:33]

nit: use "using content::SiteInstance" above. all the code in content will
eventually move to the content namespace, so doing this now saves more work in
the future. also in other content files

[ananta, 2012/01/24 23:46:26]

Done.

+    const GURL& url) {
   std::string site =
-      SiteInstance::GetSiteForURL(browser_context_, url)
+      content::SiteInstance::GetSiteForURL(browser_context_, url)
           .possibly_invalid_spec();
 
   SiteInstanceMap* map = GetSiteInstanceMap(browser_context_, url);
@@ -89,17 +90,18 @@
   }
 
   // No current SiteInstance for this site, so let's create one.
-  SiteInstance* instance = new SiteInstance(this);
+  SiteInstanceImpl* instance = new SiteInstanceImpl(this);
 
   // Set the site of this new SiteInstance, which will register it with us.
   instance->SetSite(url);
   return instance;
 }
 
-void BrowsingInstance::RegisterSiteInstance(SiteInstance* site_instance) {
-  DCHECK(site_instance->browsing_instance_ == this);
-  DCHECK(site_instance->has_site());
-  std::string site = site_instance->site().possibly_invalid_spec();
+void BrowsingInstance::RegisterSiteInstance(
+    content::SiteInstance* site_instance) {
+  DCHECK(site_instance->GetBrowsingInstance() == this);
+  DCHECK(site_instance->HasSite());
+  std::string site = site_instance->GetSite().possibly_invalid_spec();
 
   // Only register if we don't have a SiteInstance for this site already.
   // It's possible to have two SiteInstances point to the same site if two
@@ -107,7 +109,7 @@
   // register them until DidNavigate.)  If there is a previously existing
   // SiteInstance for this site, we just won't register the new one.
   SiteInstanceMap* map = GetSiteInstanceMap(browser_context_,
-                                            site_instance->site());
+                                            site_instance->GetSite());
   SiteInstanceMap::iterator i = map->find(site);
   if (i == map->end()) {
     // Not previously registered, so register it.
@@ -115,10 +117,11 @@
   }
 }
 
-void BrowsingInstance::UnregisterSiteInstance(SiteInstance* site_instance) {
-  DCHECK(site_instance->browsing_instance_ == this);
-  DCHECK(site_instance->has_site());
-  std::string site = site_instance->site().possibly_invalid_spec();
+void BrowsingInstance::UnregisterSiteInstance(
+    content::SiteInstance* site_instance) {
+      DCHECK(site_instance->GetBrowsingInstance() == this);
+  DCHECK(site_instance->HasSite());
+  std::string site = site_instance->GetSite().possibly_invalid_spec();
 
   // Only unregister the SiteInstance if it is the same one that is registered
   // for the site.  (It might have been an unregistered SiteInstance.  See the
@@ -139,9 +142,10 @@
   }
 }
 
-bool BrowsingInstance::RemoveSiteInstanceFromMap(SiteInstanceMap* map,
-                                                 const std::string& site,
-                                                 SiteInstance* site_instance) {
+bool BrowsingInstance::RemoveSiteInstanceFromMap(
+    SiteInstanceMap* map,
+    const std::string& site,
+    content::SiteInstance* site_instance) {
   SiteInstanceMap::iterator i = map->find(site);
   if (i != map->end() && i->second == site_instance) {
     // Matches, so erase it.