Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 9146022: linux: don't define NO_HEAPCHECKER for every file (Closed)

Created:
8 years, 11 months ago by Evan Martin
Modified:
8 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

linux: don't define NO_HEAPCHECKER for every file Rather than globally defining NO_HEAPCHECKER and then checking that in build_config.h, let builds that opt in to heap checking directly set USE_HEAPCHECKER. Result should be equivalent builds but less stuff in the build files. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118823

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M build/build_config.h View 1 chunk +0 lines, -5 lines 0 comments Download
M build/common.gypi View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Evan Martin
8 years, 11 months ago (2012-01-23 23:00:21 UTC) #1
Evan Martin
(if this looks good to you, please commit-queue it to save a roundtrip)
8 years, 11 months ago (2012-01-23 23:14:50 UTC) #2
commit-bot: I haz the power
No LGTM from any valid reviewer yet. Even if a LGTM may have been provided, ...
8 years, 11 months ago (2012-01-24 08:48:56 UTC) #3
Alexander Potapenko
On 2012/01/23 23:14:50, Evan Martin wrote: > (if this looks good to you, please commit-queue ...
8 years, 11 months ago (2012-01-24 08:49:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/evan@chromium.org/9146022/1
8 years, 11 months ago (2012-01-24 08:50:09 UTC) #5
commit-bot: I haz the power
Try job failure for 9146022-1 (retry) on win_rel for steps "browser_tests, ui_tests" (clobber build). It's ...
8 years, 11 months ago (2012-01-24 10:49:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/evan@chromium.org/9146022/1
8 years, 11 months ago (2012-01-24 10:52:19 UTC) #7
commit-bot: I haz the power
8 years, 11 months ago (2012-01-24 12:26:41 UTC) #8
Change committed as 118823

Powered by Google App Engine
This is Rietveld 408576698