Add the ability to link to members and constructors of other classes in Dartdoc.

Add the ability to link to members and constructors of other classes in Dartdoc.

The syntax is [Class.member] and [new Class], respectively.
[new Class.namedConstructor] also works.

Committed: https://code.google.com/p/dart/source/detail?r=3217

[nweiz, 2012-01-09 23:50:07]

I've confirmed that static members share a namespace with instance members, so
[Class.member] should work fine.

[Bob Nystrom, 2012-01-10 00:40:41]

A couple of suggestions, but LGTM.

http://codereview.chromium.org/9146016/diff/1/utils/dartdoc/dartdoc.dart
File utils/dartdoc/dartdoc.dart (right):

http://codereview.chromium.org/9146016/diff/1/utils/dartdoc/dartdoc.dart#newc...
utils/dartdoc/dartdoc.dart:794: findMember(Type type, String name) {
Shadowing name here, makes this already-confusing method even more confusing.
Can you rename one of them?

http://codereview.chromium.org/9146016/diff/1/utils/dartdoc/dartdoc.dart#newc...
utils/dartdoc/dartdoc.dart:833: final classAndName =
name.substring(4).split('.');
I think a regex would be simpler here: 'new (\w+).(\w+)'.

http://codereview.chromium.org/9146016/diff/1/utils/dartdoc/dartdoc.dart#newc...
utils/dartdoc/dartdoc.dart:841: })();
This is clever, but perverse. :) If using a regex simplifies your control flow
enough that you don't need all of the early returns, I'd try to get rid of this.
Otherwise, maybe just make this a standalone method, or a local named function
that you call after defining.

http://codereview.chromium.org/9146016/diff/1/utils/dartdoc/test/dartdoc_test...
File utils/dartdoc/test/dartdoc_tests.dart (right):

http://codereview.chromium.org/9146016/diff/1/utils/dartdoc/test/dartdoc_test...
utils/dartdoc/test/dartdoc_tests.dart:175: 
Woo tests!

[nweiz, 2012-01-10 01:51:55]

http://codereview.chromium.org/9146016/diff/1/utils/dartdoc/dartdoc.dart
File utils/dartdoc/dartdoc.dart (right):

http://codereview.chromium.org/9146016/diff/1/utils/dartdoc/dartdoc.dart#newc...
utils/dartdoc/dartdoc.dart:794: findMember(Type type, String name) {
On 2012/01/10 00:40:41, Bob Nystrom wrote:
> Shadowing name here, makes this already-confusing method even more confusing.
> Can you rename one of them?

Done.

http://codereview.chromium.org/9146016/diff/1/utils/dartdoc/dartdoc.dart#newc...
utils/dartdoc/dartdoc.dart:833: final classAndName =
name.substring(4).split('.');
On 2012/01/10 00:40:41, Bob Nystrom wrote:
> I think a regex would be simpler here: 'new (\w+).(\w+)'.

Done.

http://codereview.chromium.org/9146016/diff/1/utils/dartdoc/dartdoc.dart#newc...
utils/dartdoc/dartdoc.dart:841: })();
On 2012/01/10 00:40:41, Bob Nystrom wrote:
> This is clever, but perverse. :) If using a regex simplifies your control flow
> enough that you don't need all of the early returns, I'd try to get rid of
this.
> Otherwise, maybe just make this a standalone method, or a local named function
> that you call after defining.

I had this as a local named function before this, but it felt spaghetti-esque
when reading the code, what with having to jump backwards to figure out what the
function was doing. I think this approach better captures the control flow I'm
trying to express, despite being somewhat unconventional.