Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Unified Diff: content/public/browser/browser_thread.h

Issue 9146007: Get rid of BrowserThread::WEB_SOCKET_PROXY. BrowserThread is only for threads that are used in ma... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/browser_thread_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/browser_thread.h
===================================================================
--- content/public/browser/browser_thread.h (revision 116795)
+++ content/public/browser/browser_thread.h (working copy)
@@ -83,12 +83,10 @@
// This is the thread that processes IPC and network messages.
IO,
-#if defined(OS_CHROMEOS)
- // This thread runs websocket to TCP proxy.
- // TODO(dilmah): remove this thread, instead implement this functionality
- // as hooks into websocket layer.
- WEB_SOCKET_PROXY,
-#endif
+ // NOTE: do not add new threads here that are only used by a small number of
+ // files. Instead you should just use a Thread class and pass its
+ // MessageLoopProxy around. Named threads there are only for threads that
+ // are used in many places.
// This identifier does not represent a thread. Instead it counts the
// number of well-known threads. Insert new well-known threads before this
« no previous file with comments | « content/browser/browser_thread_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698