Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Side by Side Diff: content/public/browser/browser_thread.h

Issue 9146007: Get rid of BrowserThread::WEB_SOCKET_PROXY. BrowserThread is only for threads that are used in ma... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/browser/browser_thread_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_BROWSER_THREAD_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_BROWSER_THREAD_H_
6 #define CONTENT_PUBLIC_BROWSER_BROWSER_THREAD_H_ 6 #define CONTENT_PUBLIC_BROWSER_BROWSER_THREAD_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 76
77 // Used to launch and terminate Chrome processes. 77 // Used to launch and terminate Chrome processes.
78 PROCESS_LAUNCHER, 78 PROCESS_LAUNCHER,
79 79
80 // This is the thread to handle slow HTTP cache operations. 80 // This is the thread to handle slow HTTP cache operations.
81 CACHE, 81 CACHE,
82 82
83 // This is the thread that processes IPC and network messages. 83 // This is the thread that processes IPC and network messages.
84 IO, 84 IO,
85 85
86 #if defined(OS_CHROMEOS) 86 // NOTE: do not add new threads here that are only used by a small number of
87 // This thread runs websocket to TCP proxy. 87 // files. Instead you should just use a Thread class and pass its
88 // TODO(dilmah): remove this thread, instead implement this functionality 88 // MessageLoopProxy around. Named threads there are only for threads that
89 // as hooks into websocket layer. 89 // are used in many places.
90 WEB_SOCKET_PROXY,
91 #endif
92 90
93 // This identifier does not represent a thread. Instead it counts the 91 // This identifier does not represent a thread. Instead it counts the
94 // number of well-known threads. Insert new well-known threads before this 92 // number of well-known threads. Insert new well-known threads before this
95 // identifier. 93 // identifier.
96 ID_COUNT 94 ID_COUNT
97 }; 95 };
98 96
99 // These are the same methods in message_loop.h, but are guaranteed to either 97 // These are the same methods in message_loop.h, but are guaranteed to either
100 // get posted to the MessageLoop if it's still alive, or be deleted otherwise. 98 // get posted to the MessageLoop if it's still alive, or be deleted otherwise.
101 // They return true iff the thread existed and the task was posted. Note that 99 // They return true iff the thread existed and the task was posted. Note that
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 private: 224 private:
227 friend class BrowserThreadImpl; 225 friend class BrowserThreadImpl;
228 226
229 BrowserThread() {} 227 BrowserThread() {}
230 DISALLOW_COPY_AND_ASSIGN(BrowserThread); 228 DISALLOW_COPY_AND_ASSIGN(BrowserThread);
231 }; 229 };
232 230
233 } // namespace content 231 } // namespace content
234 232
235 #endif // CONTENT_PUBLIC_BROWSER_BROWSER_THREAD_H_ 233 #endif // CONTENT_PUBLIC_BROWSER_BROWSER_THREAD_H_
OLDNEW
« no previous file with comments | « content/browser/browser_thread_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698