Get rid of BrowserThread::WEB_SOCKET_PROXY. BrowserThread is only for threads that are used in ma...

Get rid of BrowserThread::WEB_SOCKET_PROXY. BrowserThread is only for threads that are used in many places. In cases where a specific feature/class needs a thread, it should just create it directly. Add a comment about this in BrowserThread.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117061

[jam, 2012-01-09 17:59:16]

The new thread destruction order is the same as the original change which added
this (http://codereview.chromium.org/6801008).

[jam, 2012-01-09 18:11:16]

btw is there a way for me to verify this change using the linux_chromeos build?

[zel, 2012-01-10 01:18:58]

LGTM

the code change is ok, but I am not super familiar with test procedures.
dpolukhin@ should be able to shed more light here.

[Dmitry Polukhin, 2012-01-10 08:03:08]

+ Alexey who was touched TCP proxy code recently

Running ExtensionWebSocketProxyPrivateApiTest.Pass on linux_chromeos should be
enough to test that WebSocket proxy still works. But in you test results it
failed. It looks like with your changes Proxy thread didn't start.

[jam, 2012-01-10 17:35:06]

On 2012/01/10 08:03:08, Dmitry Polukhin wrote:
> + Alexey who was touched TCP proxy code recently
> 
> Running ExtensionWebSocketProxyPrivateApiTest.Pass on linux_chromeos should be
> enough to test that WebSocket proxy still works. But in you test results it
> failed. It looks like with your changes Proxy thread didn't start.

oops, I mistakingly thought that was a flake (the name showed up as just "Pass"
on the buildbot but I should have clicked). investigating, thanks.

[jam, 2012-01-10 18:27:43]

On 2012/01/10 17:35:06, John Abd-El-Malek wrote:
> On 2012/01/10 08:03:08, Dmitry Polukhin wrote:
> > + Alexey who was touched TCP proxy code recently
> > 
> > Running ExtensionWebSocketProxyPrivateApiTest.Pass on linux_chromeos should
be
> > enough to test that WebSocket proxy still works. But in you test results it
> > failed. It looks like with your changes Proxy thread didn't start.
> 
> oops, I mistakingly thought that was a flake (the name showed up as just
"Pass"
> on the buildbot but I should have clicked). investigating, thanks.

found the issue, it was because I was calling Thread::Stop() while in the lock,
and before Shutdown() was called. fixed and verified on linux_chromeos build

[Dmitry Polukhin, 2012-01-10 19:45:11]

LGTM but please run trybots before commit.

[jam, 2012-01-10 19:47:07]

I always do :) check out patchset 2. patchset 3 just removed two files that
accidentally made it into patchset 2 (they just removed unnecessary
includes), so i didn't run trybots on ps3 after removing those files.

On Tue, Jan 10, 2012 at 11:45 AM, <dpolukhin@chromium.org> wrote:

> LGTM but please run trybots before commit.
>
>
http://codereview.chromium.**org/9146007/<http://codereview.chromium.org/9146...
>