Change the thread interface in runtime/platform and use it starting all threads

runtime/bin/thread_pool.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef BIN_THREAD_POOL_H_
 #define BIN_THREAD_POOL_H_
 
 #include "bin/builtin.h"
 #include "platform/globals.h"
 #include "platform/thread.h"
 
-// Declare the OS-specific types ahead of defining the generic classes.
-#if defined(TARGET_OS_LINUX)
-#include "bin/thread_pool_linux.h"
-#elif defined(TARGET_OS_MACOS)
-#include "bin/thread_pool_macos.h"
-#elif defined(TARGET_OS_WINDOWS)
-#include "bin/thread_pool_win.h"
-#else
-#error Unknown target os.
-#endif
-
-
 typedef void* Task;
 
 
 class TaskQueueEntry {
  public:
   explicit TaskQueueEntry(Task task) : task_(task), next_(NULL) {}
 
   Task task() { return task_; }
 
   TaskQueueEntry* next() { return next_; }
@@ skipping 16 matching lines @@
   TaskQueueEntry* Remove();
   void Shutdown();
 
  private:
   bool terminate_;
   TaskQueueEntry* head_;
   TaskQueueEntry* tail_;
   dart::Monitor monitor_;
 
   DISALLOW_COPY_AND_ASSIGN(TaskQueue);
 };

[siva, 2012/01/27 18:53:17]

There was a comment by Ivan earlier about hiding the implementation of TaskQueue
and TaskQueueEntry inside of ThreadPool. Are you considering that for this CL?

[Søren Gjesse, 2012/01/30 14:42:57]

I moved thread_pool cleanup to separate CL,
https://chromiumcodereview.appspot.com/9212043 (which is based off this).

[siva, 2012/02/02 05:53:07]

Ok, thanks for clarifying that.

 
 
 class ThreadPool {
  public:
   typedef void* (*TaskHandler)(void* args);
 
   ThreadPool(TaskHandler task_handler, int initial_size = 4)
       : terminate_(false),
         size_(initial_size),
         task_handler_(task_handler) {}
 
   void Start();
   void Shutdown();
 
   void InsertTask(Task task);
 
+  void ThreadTerminated();
+
  private:
   Task WaitForTask();
 
-  static void* Main(void* args);
+  static void Main(uword args);
 
   TaskQueue queue_;
   // TODO(sgjesse): Move the monitor in TaskQueue to ThreadPool and
   // obtain it for updating terminate_.
+  dart::Monitor monitor_;
   bool terminate_;
   int size_;  // Number of threads.
   TaskHandler task_handler_;
-  ThreadPoolData data_;
 
   DISALLOW_COPY_AND_ASSIGN(ThreadPool);
 };
 
 #endif  // BIN_THREAD_POOL_H_