Change the thread interface in runtime/platform and use it starting all threads

runtime/bin/eventhandler_win.cc

-// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+#include "bin/eventhandler.h"
+
 #include <process.h>
 #include <winsock2.h>
 #include <ws2tcpip.h>
 #include <mswsock.h>
 
 #include "bin/builtin.h"
-#include "bin/eventhandler.h"
 #include "bin/socket.h"
 
 
 static const int kInfinityTimeout = -1;
 
 
 int64_t GetCurrentTimeMilliseconds() {
   static const int64_t kTimeEpoc = 116444736000000000LL;
 
   // Although win32 uses 64-bit integers for representing timestamps,
@@ skipping 794 matching lines @@
   msg->dart_port = dart_port;
   msg->data = data;
   BOOL ok = PostQueuedCompletionStatus(
       completion_port_, 0, NULL, reinterpret_cast<OVERLAPPED*>(msg));
   if (!ok) {
     FATAL("PostQueuedCompletionStatus failed");
   }
 }
 
 
-static unsigned int __stdcall EventHandlerThread(void* args) {
+static void EventHandlerThread(uword args) {
   EventHandlerImplementation* handler =
       reinterpret_cast<EventHandlerImplementation*>(args);

[siva, 2012/01/27 18:53:17]

ASSERT(handler != NULL);

[Søren Gjesse, 2012/01/30 14:42:57]

Done.

   while (true) {
     DWORD bytes;
     ULONG_PTR key;
     OVERLAPPED* overlapped;
     intptr_t millis = handler->GetTimeout();
     BOOL ok = GetQueuedCompletionStatus(handler->completion_port(),
                                         &bytes,
                                         &key,
                                         &overlapped,
                                         millis);
@@ skipping 31 matching lines @@
       handler->HandleInterrupt(msg);
       delete msg;
     } else {
       handler->HandleIOCompletion(bytes, key, overlapped);
     }
   }
 }
 
 
 void EventHandlerImplementation::StartEventHandler() {
-  uint32_t tid;
-  uintptr_t thread_handle =
-      _beginthreadex(NULL, 32 * 1024, EventHandlerThread, this, 0, &tid);
-  if (thread_handle == -1) {
-    FATAL("Failed to start event handler thread");
+  int result = dart::Thread::Start(EventHandlerThread,
+                                   reinterpret_cast<uword>(this));
+  if (result != 0) {
+    FATAL1("Failed to start event handler thread %d", result);
   }
 
   // Initialize Winsock32
   if (!Socket::Initialize()) {
     FATAL("Failed to initialized Windows sockets");
   }
 }