Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 9139076: Added bounds checks to the URLLoader prefetch buffer threshhold. (Closed)

Created:
8 years, 11 months ago by raymes
Modified:
8 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Added bounds checks to the URLLoader prefetch buffer threshhold. BUG=89842 TEST=./ui_tests --gtest_filter=PPAPITest.URLLoader*PrefetchBufferThreshold Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117970

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : Merged tests #

Total comments: 1

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M chrome/test/ui/ppapi_uitest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/tests/test_url_loader.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M ppapi/tests/test_url_loader.cc View 1 2 3 3 chunks +34 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_url_request_info_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
raymes
8 years, 11 months ago (2012-01-13 15:06:04 UTC) #1
dmichael (off chromium)
lgtm http://codereview.chromium.org/9139076/diff/6/ppapi/tests/test_url_loader.cc File ppapi/tests/test_url_loader.cc (right): http://codereview.chromium.org/9139076/diff/6/ppapi/tests/test_url_loader.cc#newcode914 ppapi/tests/test_url_loader.cc:914: I think it would make sense to collapse ...
8 years, 11 months ago (2012-01-13 17:46:02 UTC) #2
Jay Civelli
LGTM http://codereview.chromium.org/9139076/diff/6001/ppapi/tests/test_url_loader.cc File ppapi/tests/test_url_loader.cc (right): http://codereview.chromium.org/9139076/diff/6001/ppapi/tests/test_url_loader.cc#newcode882 ppapi/tests/test_url_loader.cc:882: int32_t rv = OpenUntrusted(request); Nit: why not returning ...
8 years, 11 months ago (2012-01-17 17:31:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/9139076/9001
8 years, 11 months ago (2012-01-17 21:02:37 UTC) #4
commit-bot: I haz the power
8 years, 11 months ago (2012-01-17 22:10:17 UTC) #5
Change committed as 117970

Powered by Google App Engine
This is Rietveld 408576698