Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 9139059: Use PCH by default in VS 2010. (Closed)

Created:
8 years, 11 months ago by Jói
Modified:
8 years, 11 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Use PCH by default in VS 2010. According to my testing, VS 2010 does not have problem (b) documented at http://code.google.com/p/chromium/wiki/WindowsPrecompiledHeaders, i.e. it rebuilds the PCH file when necessary because of e.g. preprocessor flag changes. Since we aren't using VS 2010 for official builds, if problem (a) (out of memory) is encountered with VS 2010 when we make the switch to using it for official builds, we can simply turn PCH off explicitly in the include.gypi for the official bots. This change has no effect on VS 2008 bots or users. BUG=110001 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117845

Patch Set 1 #

Patch Set 2 : Merge to LKGR, pure merge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M build/common.gypi View 1 2 chunks +22 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jói
8 years, 11 months ago (2012-01-12 13:22:31 UTC) #1
M-A Ruel
lgtm, thanks.
8 years, 11 months ago (2012-01-12 14:34:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/9139059/7001
8 years, 11 months ago (2012-01-16 10:30:52 UTC) #3
commit-bot: I haz the power
8 years, 11 months ago (2012-01-16 11:45:20 UTC) #4
Change committed as 117845

Powered by Google App Engine
This is Rietveld 408576698