Issue 9139054: Revert 117399 - Make it possible to have 1 PpapiGlobals per thread. Update unit tests.

Issue 9139054: Revert 117399 - Make it possible to have 1 PpapiGlobals per thread. Update unit tests. (Closed)

Created:
8 years, 11 months ago by tommi (sloooow) - chröme

Modified:
8 years, 11 months ago

Reviewers:
dmichael (off chromium)

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 117399 - Make it possible to have 1 PpapiGlobals per thread. Update unit tests. Reason for rever: Broke the sizes check on the mac clobber bot. This allows us to distinguish trackers in the unit tests, instead of all vars/resources going in 1 tracker. This should also allow us to unit-test PPB proxies. BUG= TEST= Review URL: http://codereview.chromium.org/9034035 TBR=dmichael@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117414

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+223 lines, -346 lines)			Patch
M	ppapi/proxy/host_dispatcher.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	ppapi/proxy/host_var_serialization_rules.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	ppapi/proxy/host_var_serialization_rules.cc	View	5 chunks	+19 lines, -19 lines	0 comments	Download
M	ppapi/proxy/plugin_globals.h	View	5 chunks	+2 lines, -12 lines	0 comments	Download
M	ppapi/proxy/plugin_globals.cc	View	3 chunks	+2 lines, -21 lines	0 comments	Download
M	ppapi/proxy/plugin_resource_tracker.h	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	ppapi/proxy/plugin_resource_tracker.cc	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	ppapi/proxy/plugin_var_serialization_rules.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ppapi/proxy/plugin_var_tracker.h	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	ppapi/proxy/plugin_var_tracker.cc	View	2 chunks	+16 lines, -1 line	0 comments	Download
M	ppapi/proxy/ppapi_proxy_test.h	View	6 chunks	+1 line, -12 lines	0 comments	Download
M	ppapi/proxy/ppapi_proxy_test.cc	View	8 chunks	+4 lines, -12 lines	0 comments	Download
M	ppapi/proxy/ppb_var_unittest.cc	View	8 chunks	+7 lines, -21 lines	0 comments	Download
M	ppapi/proxy/ppp_instance_private_proxy_unittest.cc	View	7 chunks	+62 lines, -55 lines	0 comments	Download
M	ppapi/proxy/ppp_instance_proxy_unittest.cc	View	6 chunks	+6 lines, -21 lines	0 comments	Download
M	ppapi/proxy/ppp_messaging_proxy_unittest.cc	View	3 chunks	+34 lines, -16 lines	0 comments	Download
M	ppapi/proxy/serialized_var_unittest.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	ppapi/shared_impl/ppapi_globals.h	View	4 chunks	+2 lines, -41 lines	0 comments	Download
M	ppapi/shared_impl/ppapi_globals.cc	View	3 chunks	+2 lines, -33 lines	0 comments	Download
M	ppapi/shared_impl/proxy_lock.h	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	ppapi/shared_impl/proxy_lock.cc	View	1 chunk	+17 lines, -8 lines	0 comments	Download
M	ppapi/shared_impl/test_globals.h	View	3 chunks	+1 line, -3 lines	0 comments	Download
M	ppapi/shared_impl/test_globals.cc	View	3 chunks	+1 line, -10 lines	0 comments	Download
M	ppapi/shared_impl/var_tracker.h	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	ppapi/shared_impl/var_tracker.cc	View	2 chunks	+1 line, -16 lines	0 comments	Download
M	webkit/plugins/ppapi/host_globals.h	View	4 chunks	+2 lines, -10 lines	0 comments	Download
M	webkit/plugins/ppapi/host_globals.cc	View	4 chunks	+2 lines, -16 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages