Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 9139051: Cosmetic changes ("set up" is a verb, "setup" is a noun). (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.h ('k') | src/ia32/macro-assembler-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4130 matching lines...) Expand 10 before | Expand all | Expand 10 after
4141 __ mov(ebx, FieldOperand(eax, HeapObject::kMapOffset)); 4141 __ mov(ebx, FieldOperand(eax, HeapObject::kMapOffset));
4142 // Load the map's "bit field 2". We only need the first byte, 4142 // Load the map's "bit field 2". We only need the first byte,
4143 // but the following masking takes care of that anyway. 4143 // but the following masking takes care of that anyway.
4144 __ mov(ebx, FieldOperand(ebx, Map::kBitField2Offset)); 4144 __ mov(ebx, FieldOperand(ebx, Map::kBitField2Offset));
4145 // Retrieve elements_kind from bit field 2. 4145 // Retrieve elements_kind from bit field 2.
4146 __ and_(ebx, Map::kElementsKindMask); 4146 __ and_(ebx, Map::kElementsKindMask);
4147 __ cmp(ebx, boilerplate_elements_kind << Map::kElementsKindShift); 4147 __ cmp(ebx, boilerplate_elements_kind << Map::kElementsKindShift);
4148 DeoptimizeIf(not_equal, instr->environment()); 4148 DeoptimizeIf(not_equal, instr->environment());
4149 } 4149 }
4150 4150
4151 // Setup the parameters to the stub/runtime call. 4151 // Set up the parameters to the stub/runtime call.
4152 __ mov(eax, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset)); 4152 __ mov(eax, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset));
4153 __ push(FieldOperand(eax, JSFunction::kLiteralsOffset)); 4153 __ push(FieldOperand(eax, JSFunction::kLiteralsOffset));
4154 __ push(Immediate(Smi::FromInt(instr->hydrogen()->literal_index()))); 4154 __ push(Immediate(Smi::FromInt(instr->hydrogen()->literal_index())));
4155 // Boilerplate already exists, constant elements are never accessed. 4155 // Boilerplate already exists, constant elements are never accessed.
4156 // Pass an empty fixed array. 4156 // Pass an empty fixed array.
4157 __ push(Immediate(Handle<FixedArray>(heap->empty_fixed_array()))); 4157 __ push(Immediate(Handle<FixedArray>(heap->empty_fixed_array())));
4158 4158
4159 // Pick the right runtime function or stub to call. 4159 // Pick the right runtime function or stub to call.
4160 int length = instr->hydrogen()->length(); 4160 int length = instr->hydrogen()->length();
4161 if (instr->hydrogen()->IsCopyOnWrite()) { 4161 if (instr->hydrogen()->IsCopyOnWrite()) {
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
4249 EmitDeepCopy(instr->hydrogen()->boilerplate(), eax, ebx, &offset); 4249 EmitDeepCopy(instr->hydrogen()->boilerplate(), eax, ebx, &offset);
4250 ASSERT_EQ(size, offset); 4250 ASSERT_EQ(size, offset);
4251 } 4251 }
4252 4252
4253 4253
4254 void LCodeGen::DoObjectLiteralGeneric(LObjectLiteralGeneric* instr) { 4254 void LCodeGen::DoObjectLiteralGeneric(LObjectLiteralGeneric* instr) {
4255 ASSERT(ToRegister(instr->context()).is(esi)); 4255 ASSERT(ToRegister(instr->context()).is(esi));
4256 Handle<FixedArray> constant_properties = 4256 Handle<FixedArray> constant_properties =
4257 instr->hydrogen()->constant_properties(); 4257 instr->hydrogen()->constant_properties();
4258 4258
4259 // Setup the parameters to the stub/runtime call. 4259 // Set up the parameters to the stub/runtime call.
4260 __ mov(eax, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset)); 4260 __ mov(eax, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset));
4261 __ push(FieldOperand(eax, JSFunction::kLiteralsOffset)); 4261 __ push(FieldOperand(eax, JSFunction::kLiteralsOffset));
4262 __ push(Immediate(Smi::FromInt(instr->hydrogen()->literal_index()))); 4262 __ push(Immediate(Smi::FromInt(instr->hydrogen()->literal_index())));
4263 __ push(Immediate(constant_properties)); 4263 __ push(Immediate(constant_properties));
4264 int flags = instr->hydrogen()->fast_elements() 4264 int flags = instr->hydrogen()->fast_elements()
4265 ? ObjectLiteral::kFastElements 4265 ? ObjectLiteral::kFastElements
4266 : ObjectLiteral::kNoFlags; 4266 : ObjectLiteral::kNoFlags;
4267 flags |= instr->hydrogen()->has_function() 4267 flags |= instr->hydrogen()->has_function()
4268 ? ObjectLiteral::kHasFunction 4268 ? ObjectLiteral::kHasFunction
4269 : ObjectLiteral::kNoFlags; 4269 : ObjectLiteral::kNoFlags;
(...skipping 351 matching lines...) Expand 10 before | Expand all | Expand 10 after
4621 this, pointers, Safepoint::kLazyDeopt); 4621 this, pointers, Safepoint::kLazyDeopt);
4622 __ InvokeBuiltin(Builtins::IN, CALL_FUNCTION, safepoint_generator); 4622 __ InvokeBuiltin(Builtins::IN, CALL_FUNCTION, safepoint_generator);
4623 } 4623 }
4624 4624
4625 4625
4626 #undef __ 4626 #undef __
4627 4627
4628 } } // namespace v8::internal 4628 } } // namespace v8::internal
4629 4629
4630 #endif // V8_TARGET_ARCH_IA32 4630 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.h ('k') | src/ia32/macro-assembler-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698