Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 9139051: Cosmetic changes ("set up" is a verb, "setup" is a noun). (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/simulator-arm.cc ('k') | src/assembler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1126 matching lines...) Expand 10 before | Expand all | Expand 10 after
1137 __ Move(scratch3, Handle<Object>(callback->data())); 1137 __ Move(scratch3, Handle<Object>(callback->data()));
1138 } 1138 }
1139 __ Push(reg, scratch3, name_reg); 1139 __ Push(reg, scratch3, name_reg);
1140 __ mov(r0, sp); // r0 = Handle<String> 1140 __ mov(r0, sp); // r0 = Handle<String>
1141 1141
1142 const int kApiStackSpace = 1; 1142 const int kApiStackSpace = 1;
1143 FrameScope frame_scope(masm(), StackFrame::MANUAL); 1143 FrameScope frame_scope(masm(), StackFrame::MANUAL);
1144 __ EnterExitFrame(false, kApiStackSpace); 1144 __ EnterExitFrame(false, kApiStackSpace);
1145 1145
1146 // Create AccessorInfo instance on the stack above the exit frame with 1146 // Create AccessorInfo instance on the stack above the exit frame with
1147 // scratch2 (internal::Object **args_) as the data. 1147 // scratch2 (internal::Object** args_) as the data.
1148 __ str(scratch2, MemOperand(sp, 1 * kPointerSize)); 1148 __ str(scratch2, MemOperand(sp, 1 * kPointerSize));
1149 __ add(r1, sp, Operand(1 * kPointerSize)); // r1 = AccessorInfo& 1149 __ add(r1, sp, Operand(1 * kPointerSize)); // r1 = AccessorInfo&
1150 1150
1151 const int kStackUnwindSpace = 4; 1151 const int kStackUnwindSpace = 4;
1152 Address getter_address = v8::ToCData<Address>(callback->getter()); 1152 Address getter_address = v8::ToCData<Address>(callback->getter());
1153 ApiFunction fun(getter_address); 1153 ApiFunction fun(getter_address);
1154 ExternalReference ref = 1154 ExternalReference ref =
1155 ExternalReference(&fun, 1155 ExternalReference(&fun,
1156 ExternalReference::DIRECT_GETTER_CALL, 1156 ExternalReference::DIRECT_GETTER_CALL,
1157 masm()->isolate()); 1157 masm()->isolate());
(...skipping 1240 matching lines...) Expand 10 before | Expand all | Expand 10 after
2398 GenerateGlobalReceiverCheck(object, holder, name, &miss); 2398 GenerateGlobalReceiverCheck(object, holder, name, &miss);
2399 GenerateLoadFunctionFromCell(cell, function, &miss); 2399 GenerateLoadFunctionFromCell(cell, function, &miss);
2400 2400
2401 // Patch the receiver on the stack with the global proxy if 2401 // Patch the receiver on the stack with the global proxy if
2402 // necessary. 2402 // necessary.
2403 if (object->IsGlobalObject()) { 2403 if (object->IsGlobalObject()) {
2404 __ ldr(r3, FieldMemOperand(r0, GlobalObject::kGlobalReceiverOffset)); 2404 __ ldr(r3, FieldMemOperand(r0, GlobalObject::kGlobalReceiverOffset));
2405 __ str(r3, MemOperand(sp, argc * kPointerSize)); 2405 __ str(r3, MemOperand(sp, argc * kPointerSize));
2406 } 2406 }
2407 2407
2408 // Setup the context (function already in r1). 2408 // Set up the context (function already in r1).
2409 __ ldr(cp, FieldMemOperand(r1, JSFunction::kContextOffset)); 2409 __ ldr(cp, FieldMemOperand(r1, JSFunction::kContextOffset));
2410 2410
2411 // Jump to the cached code (tail call). 2411 // Jump to the cached code (tail call).
2412 Counters* counters = masm()->isolate()->counters(); 2412 Counters* counters = masm()->isolate()->counters();
2413 __ IncrementCounter(counters->call_global_inline(), 1, r3, r4); 2413 __ IncrementCounter(counters->call_global_inline(), 1, r3, r4);
2414 ParameterCount expected(function->shared()->formal_parameter_count()); 2414 ParameterCount expected(function->shared()->formal_parameter_count());
2415 CallKind call_kind = CallICBase::Contextual::decode(extra_state_) 2415 CallKind call_kind = CallICBase::Contextual::decode(extra_state_)
2416 ? CALL_AS_FUNCTION 2416 ? CALL_AS_FUNCTION
2417 : CALL_AS_METHOD; 2417 : CALL_AS_METHOD;
2418 // We call indirectly through the code field in the function to 2418 // We call indirectly through the code field in the function to
(...skipping 1793 matching lines...) Expand 10 before | Expand all | Expand 10 after
4212 Handle<Code> ic_miss = masm->isolate()->builtins()->KeyedStoreIC_Miss(); 4212 Handle<Code> ic_miss = masm->isolate()->builtins()->KeyedStoreIC_Miss();
4213 __ Jump(ic_miss, RelocInfo::CODE_TARGET); 4213 __ Jump(ic_miss, RelocInfo::CODE_TARGET);
4214 } 4214 }
4215 4215
4216 4216
4217 #undef __ 4217 #undef __
4218 4218
4219 } } // namespace v8::internal 4219 } } // namespace v8::internal
4220 4220
4221 #endif // V8_TARGET_ARCH_ARM 4221 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/simulator-arm.cc ('k') | src/assembler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698