use EXECUTABLE_SUFFIX instead of exe_ext in yasm.gyp

use EXECUTABLE_SUFFIX instead of exe_ext in yasm.gyp

BUG=95406
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117450

[scottmg, 2012-01-12 00:11:42]

Re: http://codereview.chromium.org/9181008/

[Ryan Sleevi, 2012-01-12 00:19:31]

You may also wish to use <(EXECUTABLE_PREFIX), since genmacro is a target built
by yasm.gyp

I'm not aware of any of our targets setting it, atm, but a quick codesearch
turns up a mix of some targets using it, some not, so it seems easy/low-cost to
add it.

To save typing, you could slap it in a variable, with a proper _file/_path
suffix in the variable name for path normalization rules (
http://code.google.com/p/gyp/wiki/InputFormatReference#Pathname_Relativization )
 and then re-use the variable in all of these places. 

An example is src/build/protoc.gypi , though it doesn't use the _file/_path for
the protoc binary.

[Ryan Sleevi, 2012-01-12 00:19:47]

That was to say, LGTM, mod those nits :)

[scottmg, 2012-01-12 00:28:27]

There's a whole bunch of tools, not just one, so it seems a bit mucky
either way? (genperf, genstrings, genmacro, re2c, genversion, ...)

On Wed, Jan 11, 2012 at 4:19 PM, <rsleevi@chromium.org> wrote:

> You may also wish to use <(EXECUTABLE_PREFIX), since genmacro is a target
> built
> by yasm.gyp
>
> I'm not aware of any of our targets setting it, atm, but a quick codesearch
> turns up a mix of some targets using it, some not, so it seems
> easy/low-cost to
> add it.
>
> To save typing, you could slap it in a variable, with a proper _file/_path
> suffix in the variable name for path normalization rules (
> http://code.google.com/p/gyp/**wiki/InputFormatReference#**
>
Pathname_Relativization<http://code.google.com/p/gyp/wiki/InputFormatReference#Pathname_Relativization>)
>  and then re-use the variable in all of these places.
>
> An example is src/build/protoc.gypi , though it doesn't use the
> _file/_path for
> the protoc binary.
>
>
>
>
http://codereview.chromium.**org/9139038/<http://codereview.chromium.org/9139...
>

[Ryan Sleevi, 2012-01-12 00:39:01]

Fair enough. I should have paid closer attention.

I still think <(EXECUTABLE_PREFIX) might be worth adding here, for consistency,
but the change still LGTM either way.

[scottmg, 2012-01-12 00:40:59]

On 2012/01/12 00:39:01, Ryan Sleevi wrote:
> I still think <(EXECUTABLE_PREFIX) might be worth adding here

Done.

[commit-bot: I haz the power, 2012-01-12 00:41:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/9139038/1003

[commit-bot: I haz the power, 2012-01-12 00:45:48]

Try job failure for 9139038-1003 on linux_clang for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[Ryan Sleevi, 2012-01-12 00:50:19]

http://codereview.chromium.org/9139038/diff/1003/third_party/yasm/yasm.gyp
File third_party/yasm/yasm.gyp (right):

http://codereview.chromium.org/9139038/diff/1003/third_party/yasm/yasm.gyp#ne...
third_party/yasm/yasm.gyp:166: '<(EXECUTABLE_PREFIX)genperf<(EXECUTABLE_SUFFIX)'
],
GYP doesn't support line continuations like this (it matches  JSON syntax more
than python dicts)

[scottmg, 2012-01-12 16:57:11]

On 2012/01/12 00:50:19, Ryan Sleevi wrote:
> http://codereview.chromium.org/9139038/diff/1003/third_party/yasm/yasm.gyp
> File third_party/yasm/yasm.gyp (right):
> 
>
http://codereview.chromium.org/9139038/diff/1003/third_party/yasm/yasm.gyp#ne...
> third_party/yasm/yasm.gyp:166:
'<(EXECUTABLE_PREFIX)genperf<(EXECUTABLE_SUFFIX)'
> ],
> GYP doesn't support line continuations like this (it matches  JSON syntax more
> than python dicts)

And... apparently we only verify that on the build machines, but just use eval
for the normal invocations. :( gyp is baffling.

[commit-bot: I haz the power, 2012-01-12 16:57:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/9139038/6001

[commit-bot: I haz the power, 2012-01-12 18:04:51]

Change committed as 117450