Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: remoting/webapp/me2mom/log_to_server.js

Issue 9139023: Enable logging from the client to the cloud. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/me2mom/log_to_server.js
diff --git a/remoting/webapp/me2mom/log_to_server.js b/remoting/webapp/me2mom/log_to_server.js
index 2d2d96e75d1829d8e5ebe34c6afcd50e953ecf43..b6c65def898a5fd7ce9f009b92d03302a9dd453f 100644
--- a/remoting/webapp/me2mom/log_to_server.js
+++ b/remoting/webapp/me2mom/log_to_server.js
@@ -28,10 +28,6 @@ remoting.LogToServer = function() {
this.sessionStartTime = 0;
};
-// Local storage key.
-/** @private */
-remoting.LogToServer.KEY_ENABLED_ = 'remoting.LogToServer.enabled';
-
// Constants used for generating a session ID.
/** @private */
remoting.LogToServer.SESSION_ID_ALPHABET_ =
@@ -47,16 +43,6 @@ remoting.LogToServer.MAX_SESSION_ID_AGE = 24 * 60 * 60 * 1000;
remoting.LogToServer.CONNECTION_STATS_ACCUMULATE_TIME = 60 * 1000;
/**
- * Enables or disables logging.
- *
- * @param {boolean} enabled whether logging is enabled
- */
-remoting.LogToServer.prototype.setEnabled = function(enabled) {
- window.localStorage.setItem(remoting.LogToServer.KEY_ENABLED_,
- enabled ? 'true' : 'false');
-}
-
-/**
* Logs a client session state change.
*
* @param {remoting.ClientSession.State} state
@@ -200,8 +186,7 @@ remoting.LogToServer.prototype.log = function(entry) {
* @return {boolean} whether logging is enabled
*/
remoting.LogToServer.prototype.isEnabled = function() {
- var value = window.localStorage.getItem(remoting.LogToServer.KEY_ENABLED_);
- return (value == 'true');
+ return true;
Jamie 2012/01/11 20:52:51 Is it worth keeping isEnabled at all? The only rea
simonmorris 2012/01/11 21:23:34 Done.
};
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698