Enable logging from the client to the cloud.

remoting/webapp/me2mom/log_to_server.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Module for sending log entries to the server.
  */
 
 'use strict';
@@ skipping 10 matching lines @@
   /** @type {remoting.StatsAccumulator} */
   this.statsAccumulator = new remoting.StatsAccumulator();
   /** @type string */
   this.sessionId = '';
   /** @type number */
   this.sessionIdGenerationTime = 0;
   /** @type number */
   this.sessionStartTime = 0;
 };
 
-// Local storage key.
-/** @private */
-remoting.LogToServer.KEY_ENABLED_ = 'remoting.LogToServer.enabled';
-
 // Constants used for generating a session ID.
 /** @private */
 remoting.LogToServer.SESSION_ID_ALPHABET_ =
     'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890';
 /** @private */
 remoting.LogToServer.SESSION_ID_LEN_ = 20;
 
 // The maximum age of a session ID, in milliseconds.
 remoting.LogToServer.MAX_SESSION_ID_AGE = 24 * 60 * 60 * 1000;
 
 // The time over which to accumulate connection statistics before logging them
 // to the server, in milliseconds.
 remoting.LogToServer.CONNECTION_STATS_ACCUMULATE_TIME = 60 * 1000;
 
 /**
- * Enables or disables logging.
- *
- * @param {boolean} enabled whether logging is enabled
- */
-remoting.LogToServer.prototype.setEnabled = function(enabled) {
-  window.localStorage.setItem(remoting.LogToServer.KEY_ENABLED_,
-     enabled ? 'true' : 'false');
-}
-
-/**
  * Logs a client session state change.
  *
  * @param {remoting.ClientSession.State} state
  * @param {remoting.ClientSession.ConnectionError} connectionError
  */
 remoting.LogToServer.prototype.logClientSessionStateChange =
     function(state, connectionError) {
   this.maybeExpireSessionId();
   // Maybe set the session ID and start time.
   if (remoting.LogToServer.isStartOfSession(state)) {
@@ skipping 123 matching lines @@
   remoting.wcs.sendIq(stanza);
 };
 
 /**
  * Whether logging is enabled.
  *
  * @private
  * @return {boolean} whether logging is enabled
  */
 remoting.LogToServer.prototype.isEnabled = function() {
-  var value = window.localStorage.getItem(remoting.LogToServer.KEY_ENABLED_);
-  return (value == 'true');
+  return true;

[Jamie, 2012/01/11 20:52:51]

Is it worth keeping isEnabled at all? The only reason I can see is to make it
easy to turn it off in the future if we wanted to, and unless isEnabled is
called in a lot of places, I don't see that being a big win.

[simonmorris, 2012/01/11 21:23:34]

Done.

 };
 
 /**
  * Sets the session ID to a random string.
  *
  * @private
  */
 remoting.LogToServer.prototype.setSessionId = function() {
   this.sessionId = remoting.LogToServer.generateSessionId();
   this.sessionIdGenerationTime = new Date().getTime();
@@ skipping 41 matching lines @@
 remoting.LogToServer.generateSessionId = function() {
   var idArray = [];
   for (var i = 0; i < remoting.LogToServer.SESSION_ID_LEN_; i++) {
     var index =
         Math.random() * remoting.LogToServer.SESSION_ID_ALPHABET_.length;
     idArray.push(
         remoting.LogToServer.SESSION_ID_ALPHABET_.slice(index, index + 1));
   }
   return idArray.join('');
 };