Issue 9139023: Enable logging from the client to the cloud.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9139023: Enable logging from the client to the cloud. (Closed)

Created:
8 years, 11 months ago by simonmorris

Modified:
8 years, 11 months ago

Reviewers:
Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable logging from the client to the cloud. BUG=106208 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117286

Patch Set 1 #

Total comments: 2

Patch Set 2 : Don't check whether logging is enabled. #

Patch Set 3 : Update year of copyright. #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -29 lines)			Patch
	M	remoting/webapp/me2mom/log_to_server.js	View	1 2	5 chunks	+1 line, -29 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jamie

LGTM, unless you agree that isEnabled should be deleted. http://codereview.chromium.org/9139023/diff/1/remoting/webapp/me2mom/log_to_server.js File remoting/webapp/me2mom/log_to_server.js (right): http://codereview.chromium.org/9139023/diff/1/remoting/webapp/me2mom/log_to_server.js#newcode189 remoting/webapp/me2mom/log_to_server.js:189: ...

8 years, 11 months ago (2012-01-11 20:52:51 UTC) #2

simonmorris

8 years, 11 months ago (2012-01-11 21:23:34 UTC) #3

http://codereview.chromium.org/9139023/diff/1/remoting/webapp/me2mom/log_to_s...
File remoting/webapp/me2mom/log_to_server.js (right):

http://codereview.chromium.org/9139023/diff/1/remoting/webapp/me2mom/log_to_s...
remoting/webapp/me2mom/log_to_server.js:189: return true;
On 2012/01/11 20:52:51, Jamie wrote:
> Is it worth keeping isEnabled at all? The only reason I can see is to make it
> easy to turn it off in the future if we wanted to, and unless isEnabled is
> called in a lot of places, I don't see that being a big win.

Done.

Expand Messages | Collapse Messages