Allow for-in to use a previously declared identifier as variable.

frog/leg/ssa/builder.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Interceptors {
   Compiler compiler;
   Interceptors(Compiler this.compiler);
 
   SourceString mapOperatorToMethodName(Operator op) {
     String name = op.source.stringValue;
@@ skipping 1307 matching lines @@
     HBasicBlock conditionExitBlock = close(new HLoopBranch(popBoolified()));
 
     Map conditionDefinitions =
         new Map<Element, HInstruction>.from(definitions);
 
     // The body.
     HBasicBlock bodyBlock = addNewBlock();
     conditionExitBlock.addSuccessor(bodyBlock);
     open(bodyBlock);
 
-    VariableDefinitions definition = node.declaredIdentifier;
-    Identifier identifier = definition.definitions.nodes.head;
-    Element variable = elements[identifier];
     String jsNextName =
         compiler.namer.instanceName(new SourceString("next"));
     push(new HInvokeDynamicMethod(jsNextName, [iterator]));
+
+    Element variable;
+    if (node.declaredIdentifier is Send) {

[ngeoffray, 2012/01/11 15:20:09]

is Send -> asSend() != null

+      variable = elements[node.declaredIdentifier];
+    } else {
+      assert(node.declaredIdentifier is VariableDefinitions);
+      variable = elements[node.declaredIdentifier.definitions.nodes.head];

[ngeoffray, 2012/01/11 15:20:09]

This will give you a type warning. I have heard we don't like those :)

[Lasse Reichstein, 2012/01/12 07:49:31]

Ah ok. Where do I disable warnings :P.

+    }
     definitions[variable] = pop();
 
     visit(node.body);
     if (isAborted()) {
       compiler.unimplemented("SsaBuilder for loop with aborting body",
                              node: node);
     }
     bodyBlock = close(new HGoto());
 
     // Update.
@@ skipping 40 matching lines @@
   }
 
   visitCatchBlock(CatchBlock node) {
     compiler.unimplemented('SsaBuilder.visitCatchBlock', node: node);
   }
 
   visitTypedef(Typedef node) {
     compiler.unimplemented('SsaBuilder.visitTypedef', node: node);
   }
 }