Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 9139012: Fix flaky error on buildbot due to virtual X server xvfb. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 50721c44ccce5ff0973b93c084c3eec6250e9010..370022f073c0a9601b26b2a025dd5793a9df1aa5 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -161,6 +161,12 @@ class TestOutput {
if (line == 'PASS' && previous_line == 'Content-Type: text/plain') {
return false;
}
+ // If the browser test failed, it may have been because DumpRenderTree
+ // and the virtual framebuffer X server didn't hook up. So return false
+ // if we get the X server error. Issue dart:1135 is filed.
+ if (line.contains('Gtk-WARNING **: cannot open display: :99')) {
+ return false;
+ }
previous_line = line;
}
return true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698