compiler/java/com/google/dart/compiler/resolver/Resolver.java - Issue 9139001: Fix http://code.google.com/p/dart/issues/detail?id=990.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/Resolver.java

Issue 9139001: Fix http://code.google.com/p/dart/issues/detail?id=990. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/Elements.java ('k') | compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/Resolver.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/Resolver.java b/compiler/java/com/google/dart/compiler/resolver/Resolver.java

index 7a376e56aceddda5c6c6eccb74c19853ddaf9ea4..439b59966967ce7f69e023ffe09eb90dacd8fdbc 100644

--- a/compiler/java/com/google/dart/compiler/resolver/Resolver.java

+++ b/compiler/java/com/google/dart/compiler/resolver/Resolver.java

@@ -499,7 +499,10 @@ public class Resolver {

ClassElement superElement = supertype.getElement();

if (!superElement.isDynamic()) {

ConstructorElement superCtor = Elements.lookupConstructor(superElement, "");

- if (superCtor != null && !superCtor.getParameters().isEmpty()) {

+ boolean superHasDefaultCtor =

+ (superCtor != null && superCtor.getParameters().isEmpty())

+ || (superCtor == null && Elements.needsImplicitDefaultConstructor(superElement));

+ if (!superHasDefaultCtor) {

onError(cls.getName(),

ResolverErrorCode.CANNOT_RESOLVE_IMPLICIT_CALL_TO_SUPER_CONSTRUCTOR,

cls.getSuperclass());