Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9138027: PPAPI: Reduce string copying in SerializedVar. (Closed)

Created:
8 years, 11 months ago by dmichael (off chromium)
Modified:
8 years, 10 months ago
Reviewers:
bbudge
CC:
chromium-reviews, brettw
Visibility:
Public.

Description

PPAPI: Reduce string copying in SerializedVar. My performance test shows somewhere from 6-12% improvement. That's not bad, considering the test uses IPC, which outweighs most other work the proxy does. I wanted to do this before proxying ArrayBuffer. I might try to do a little further refactoring in another CL. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120479

Patch Set 1 : Clean up documentation #

Patch Set 2 : small comment tweak #

Total comments: 2

Patch Set 3 : tweak a comment, review fixes. #

Patch Set 4 : Duh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -112 lines) Patch
M ppapi/proxy/host_var_serialization_rules.h View 1 chunk +7 lines, -5 lines 0 comments Download
M ppapi/proxy/host_var_serialization_rules.cc View 1 2 3 4 chunks +26 lines, -21 lines 0 comments Download
M ppapi/proxy/plugin_var_serialization_rules.h View 1 chunk +6 lines, -4 lines 0 comments Download
M ppapi/proxy/plugin_var_serialization_rules.cc View 5 chunks +16 lines, -11 lines 0 comments Download
M ppapi/proxy/ppp_messaging_proxy_perftest.cc View 1 2 2 chunks +13 lines, -7 lines 0 comments Download
M ppapi/proxy/serialized_var.h View 7 chunks +24 lines, -9 lines 0 comments Download
M ppapi/proxy/serialized_var.cc View 16 chunks +34 lines, -40 lines 0 comments Download
M ppapi/proxy/serialized_var_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/var_serialization_rules.h View 1 2 3 chunks +23 lines, -14 lines 0 comments Download
M ppapi/shared_impl/var.h View 3 chunks +9 lines, -0 lines 0 comments Download
M ppapi/shared_impl/var.cc View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dmichael (off chromium)
8 years, 10 months ago (2012-02-02 22:22:08 UTC) #1
bbudge
LGTM w/nits http://codereview.chromium.org/9138027/diff/11001/ppapi/proxy/host_var_serialization_rules.cc File ppapi/proxy/host_var_serialization_rules.cc (right): http://codereview.chromium.org/9138027/diff/11001/ppapi/proxy/host_var_serialization_rules.cc#newcode57 ppapi/proxy/host_var_serialization_rules.cc:57: scoped_ptr<std::string> str_val, str_val -> 'str' for consistency? ...
8 years, 10 months ago (2012-02-03 19:51:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/9138027/11002
8 years, 10 months ago (2012-02-03 20:16:15 UTC) #3
commit-bot: I haz the power
Try job failure for 9138027-11002 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 10 months ago (2012-02-03 20:40:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/9138027/5019
8 years, 10 months ago (2012-02-03 20:49:56 UTC) #5
commit-bot: I haz the power
Try job failure for 9138027-5019 (retry) on win_rel for step "content_unittests". It's a second try, ...
8 years, 10 months ago (2012-02-03 23:33:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/9138027/5019
8 years, 10 months ago (2012-02-04 05:15:38 UTC) #7
commit-bot: I haz the power
8 years, 10 months ago (2012-02-04 16:44:39 UTC) #8 
Change committed as 120479

Powered by Google App Engine
This is Rietveld 408576698