Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_database.cc

Issue 9138003: Stop updating SafeBrowsing download hash list. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: break removal code to separate cl (should be same as patchset 2) Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/safe_browsing_database_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_database.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_database.cc b/chrome/browser/safe_browsing/safe_browsing_database.cc
index 6721f10cd508caafb2efc9d108de85c1912267b9..ea02ff6bfbca8e89be5fed149c6606bb1a5e9cbb 100644
--- a/chrome/browser/safe_browsing/safe_browsing_database.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_database.cc
@@ -1069,6 +1069,14 @@ bool SafeBrowsingDatabaseNew::UpdateStarted(
download_listnames.push_back(safe_browsing_util::kBinUrlList);
download_listnames.push_back(safe_browsing_util::kBinHashList);
UpdateChunkRanges(download_store_.get(), download_listnames, lists);
+ DCHECK_EQ(lists->back().name,
+ std::string(safe_browsing_util::kBinHashList));
+ // Remove kBinHashList entry so that we do not request updates for it from
+ // the server. The existing data will still be retained by
+ // SafeBrowsingStoreFile::DoUpdate.
+ // TODO(mattm): write some code to remove the kBinHashList data from the
+ // file?
+ lists->pop_back();
}
if (csd_whitelist_store_.get()) {
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/safe_browsing_database_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698