Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7348)

Unified Diff: chrome/common/extensions/extension_file_util_unittest.cc

Issue 9133027: Mark ExtensionFileUtil.BackgroundScriptsMustExist as flaky on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_file_util_unittest.cc
diff --git a/chrome/common/extensions/extension_file_util_unittest.cc b/chrome/common/extensions/extension_file_util_unittest.cc
index 0d6c66b210e89dc4269e223820aac20db43d674e..47eb52a841f4417e60edc7c77205cf3583ea61a1 100644
--- a/chrome/common/extensions/extension_file_util_unittest.cc
+++ b/chrome/common/extensions/extension_file_util_unittest.cc
@@ -318,7 +318,13 @@ TEST(ExtensionFileUtil, ValidateThemeUTF8) {
error;
}
-TEST(ExtensionFileUtil, BackgroundScriptsMustExist) {
+#if defined(OS_WIN)
+// This test is flaky on Windows. http://crbug.com/110279
+#define MAYBE_BackgroundScriptsMustExist FLAKY_BackgroundScriptsMustExist
+#else
+#define MAYBE_BackgroundScriptsMustExist BackgroundScriptsMustExist
+#endif
+TEST(ExtensionFileUtil, MAYBE_BackgroundScriptsMustExist) {
ScopedTempDir temp;
ASSERT_TRUE(temp.CreateUniqueTempDir());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698