Fix default apps losing the "bookmark app" bit once they get updated.

Fix default apps losing the "bookmark app" bit once they get updated.

The fix has two components:
- For updates from now on, we preserve the "bookmark app" bit if the currently
  installed extension has it.
- For users that already had their default apps updated and they lost that bit,
  we read the creation flags from the ExternalExtensionProvider that owns it
  (if any).

BUG=109791
R=aa@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117924

[Aaron Boodman, 2012-01-15 06:09:18]

lgtm w/ nit

http://codereview.chromium.org/9133023/diff/1010/chrome/browser/extensions/ex...
File chrome/browser/extensions/external_extension_provider_interface.h (right):

http://codereview.chromium.org/9133023/diff/1010/chrome/browser/extensions/ex...
chrome/browser/extensions/external_extension_provider_interface.h:86: virtual
int creation_flags() const = 0;
Virtual methods should not ever use unix_hacker style because they can't ever be
cheap/inlined.

[Mihai Parparita -not on Chrome, 2012-01-17 17:22:55]

https://chromiumcodereview.appspot.com/9133023/diff/1010/chrome/browser/exten...
File chrome/browser/extensions/external_extension_provider_interface.h (right):

https://chromiumcodereview.appspot.com/9133023/diff/1010/chrome/browser/exten...
chrome/browser/extensions/external_extension_provider_interface.h:86: virtual
int creation_flags() const = 0;
On 2012/01/15 06:09:18, Aaron Boodman wrote:
> Virtual methods should not ever use unix_hacker style because they can't ever
be
> cheap/inlined.

Done.

[commit-bot: I haz the power, 2012-01-17 17:23:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mihaip@chromium.org/9133023/10001

[commit-bot: I haz the power, 2012-01-17 18:40:57]

Change committed as 117924