Panel Overflow on Mac.

chrome/browser/ui/panels/docked_panel_strip.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/docked_panel_strip.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 122 matching lines @@
       height = max_panel_height;
 
     panel->set_restored_size(gfx::Size(width, height));
     int x = GetRightMostAvailablePosition() - width;
     int y = display_area_.bottom() - height;
 
     // Keep panel visible in the strip even if overlap would occur.
     // Panel is moved to overflow from the strip after a delay.
     // TODO(jianli): remove the guard when overflow support is enabled on other
     // platforms. http://crbug.com/105073
-#if defined(OS_WIN)
+#if defined(OS_WIN) || defined(OS_MACOSX)
     if (x < display_area_.x()) {
       x = display_area_.x();
       panel->set_has_temporary_layout(true);
       panel->set_draggable(false);
       MessageLoop::current()->PostDelayedTask(
           FROM_HERE,
           base::Bind(&DockedPanelStrip::DelayedMovePanelToOverflow,
                      base::Unretained(this),
                      panel),
           base::TimeDelta::FromMilliseconds(PanelManager::AdjustTimeInterval(
               kMoveNewPanelToOverflowDelayMs)));
     }
 #endif
     panel->Initialize(gfx::Rect(x, y, width, height));
   }
 
+  panel->ApplyVisualStyleForStrip(DOCKED_STRIP);
+
   if (panel->has_temporary_layout())
     panels_in_temporary_layout_.insert(panel);
   else
     panels_.push_back(panel);
 }
 
 int DockedPanelStrip::GetMaxPanelWidth() const {
   return static_cast<int>(display_area_.width() * kPanelMaxWidthFactor);
 }
 
@@ skipping 184 matching lines @@
 
   dragging_panel_index_ = kInvalidPanelIndex;
 
   DelayedRemove();
 }
 
 void DockedPanelStrip::OnPanelExpansionStateChanged(Panel* panel) {
   gfx::Size size = panel->restored_size();
   Panel::ExpansionState expansion_state = panel->expansion_state();
   Panel::ExpansionState old_state = panel->old_expansion_state();
   if (old_state == Panel::IN_OVERFLOW) {

[jennb, 2012/02/07 00:15:31]

Note that we do a lot of adjustments for a state change from overflow here (also
in OverflowPanelStrip). Would it be better to adjust visual style of panel here
rather than AddPanel so you don't have to call it on every panel being added?

[Dmitry Titov, 2012/02/07 00:28:26]

I think we'll change this soon because going from strip to strip will be
separated from changing the expansion states in the DockPanelStrip, right?
Also, the semantics of the method I'm adding is more of "apply style specific
for the particular strip', basically 'onAddedToStrip'... So I call it form
AddPanel - to better follow the implied semantics. I had 2 methods in earlier
version of the patch - EnterOverflow/ExitOverflow but it was too weird,
actually, because it wasn't clear what should be done in them, while I can see
useful things we can do on a panel when it goes from one strip to another.

[jennb, 2012/02/07 00:50:31]

The plan is to have Panel::MoveToStrip(new_strip). Maybe we'll move all this
logic in there in that patch.

     panel_manager_->overflow_strip()->Remove(panel);
     AddPanel(panel);
     panel->SetAppIconVisibility(true);
     panel->set_draggable(true);
   }
   switch (expansion_state) {
     case Panel::EXPANDED:
       if (old_state == Panel::TITLE_ONLY || old_state == Panel::MINIMIZED)
         DecrementMinimizedPanels();
       break;
@@ skipping 271 matching lines @@
   int rightmost_position = StartingRightPosition();
 
   size_t panel_index = 0;
   for (; panel_index < panels_.size(); ++panel_index) {
     Panel* panel = panels_[panel_index];
     gfx::Rect new_bounds(panel->GetBounds());
     int x = rightmost_position - new_bounds.width();
 
   // TODO(jianli): remove the guard when overflow support is enabled on other
   // platforms. http://crbug.com/105073
-#if defined(OS_WIN)
+#if defined(OS_WIN) || defined(OS_MACOSX)
     if (x < display_area_.x())
       break;
 #endif
 
     new_bounds.set_x(x);
     new_bounds.set_y(
         GetBottomPositionForExpansionState(panel->expansion_state()) -
             new_bounds.height());
     panel->SetPanelBounds(new_bounds);
 
     rightmost_position = new_bounds.x() - kPanelsHorizontalSpacing;
   }
 
   // TODO(jianli): remove the guard when overflow support is enabled on other
   // platforms. http://crbug.com/105073
-#if defined(OS_WIN)
+#if defined(OS_WIN) || defined(OS_MACOSX)
   // Add/remove panels from/to overflow. A change in work area or the
   // resize/removal of a panel may affect how many panels fit in the strip.
   if (panel_index < panels_.size()) {
     // Move panels to overflow in reverse to maintain their order.
     for (size_t overflow_index = panels_.size() - 1;
          overflow_index >= panel_index; --overflow_index)
       panels_[overflow_index]->SetExpansionState(Panel::IN_OVERFLOW);
   } else {
     // Attempt to add more panels from overflow to the strip.
     OverflowPanelStrip* overflow_strip = panel_manager_->overflow_strip();
@@ skipping 32 matching lines @@
 
   // Start from the bottom to avoid reshuffling.
   for (Panels::reverse_iterator iter = panels_copy.rbegin();
        iter != panels_copy.rend(); ++iter)
     (*iter)->Close();
 }
 
 bool DockedPanelStrip::is_dragging_panel() const {
   return dragging_panel_index_ != kInvalidPanelIndex;
 }