Print stop message.

runtime/vm/stub_code_ia32.cc

Index: runtime/vm/stub_code_ia32.cc
===================================================================
--- runtime/vm/stub_code_ia32.cc	(revision 3058)
+++ runtime/vm/stub_code_ia32.cc	(working copy)
@@ -114,6 +114,60 @@
 
 // Input parameters:
 //   ESP : points to return address.
+//   ESP + 4 : address of last argument in argument array.
+//   ESP + 4*EDX : address of first argument in argument array.
+//   ESP + 4*EDX + 4 : address of return value.
+//   ECX : address of the leaf function to call.
+//   EDX : number of arguments to the call.
+// Must preserve callee saved registers EDI and EBX.
+static void GenerateCallLeafStub(Assembler* assembler) {
+  const intptr_t isolate_offset = NativeArguments::isolate_offset();
+  const intptr_t argc_offset = NativeArguments::argc_offset();
+  const intptr_t argv_offset = NativeArguments::argv_offset();
+  const intptr_t retval_offset = NativeArguments::retval_offset();
+
+  __ EnterFrame(0);
+
+  // Reserve space for arguments and align frame before entering C++ world.
+  __ AddImmediate(ESP, Immediate(-sizeof(NativeArguments)));
+  if (OS::ActivationFrameAlignment() > 0) {
+    __ andl(ESP, Immediate(~(OS::ActivationFrameAlignment() - 1)));
+  }
+
+  // Pass NativeArguments structure by value and call runtime.

[Ivan Posva, 2012/01/09 17:26:42]

I don't think we should pass NativeArguments when calling leaf runtime
functions.

[regis, 2012/01/10 00:09:16]

Done.

+  __ movl(Address(ESP, isolate_offset), Immediate(0));  // Set null isolate.
+  __ movl(Address(ESP, argc_offset), EDX);  // Set argc in NativeArguments.
+  __ leal(EAX, Address(EBP, EDX, TIMES_4, 1 * kWordSize));  // Compute argv.
+  __ movl(Address(ESP, argv_offset), EAX);  // Set argv in NativeArguments.
+  __ addl(EAX, Immediate(1 * kWordSize));  // Retval is next to 1st argument.
+  __ movl(Address(ESP, retval_offset), EAX);  // Set retval in NativeArguments.
+  __ call(ECX);
+
+  __ LeaveFrame();
+  __ ret();
+}
+
+
+// Print the stop message.
+static void PrintStopMessage(NativeArguments arguments) {
+  ASSERT(arguments.Count() == 1);
+  const char* message = reinterpret_cast<const char*>(arguments.At(0));
+  OS::Print("Stop message: %s\n", message);
+}
+
+
+// Input parameters:
+//   ESP : points to return address.
+//   ESP + 4 : stop message (const char*).
+void StubCode::GeneratePrintStopMessageStub(Assembler* assembler) {
+  __ movl(ECX, Immediate(reinterpret_cast<uword>(&PrintStopMessage)));

[Ivan Posva, 2012/01/09 17:26:42]

This kills ECX and EDX as well.

[regis, 2012/01/10 00:09:16]

Done.

+  __ movl(EDX, Immediate(1));  // One argument.
+  GenerateCallLeafStub(assembler);
+}
+
+
+// Input parameters:
+//   ESP : points to return address.
 //   ESP + 4 : address of return value.
 //   EAX : address of first argument in argument array.
 //   EAX - 4*EDX + 4 : address of last argument in argument array.