More fixes for foo.continue()

client/dom/scripts/dartgenerator.py

 #!/usr/bin/python
 # Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module generates Dart APIs from the IDL database."""
 
 import emitter
 import idlnode
 import logging
@@ skipping 35 matching lines @@
     # Object, or inject SSV into the appropriate types.
     'SerializedScriptValue': 'String',
     # TODO(vsm): Automatically recognize types defined in src.
     'TimeoutHandler': 'TimeoutHandler',
     'RequestAnimationFrameCallback': 'RequestAnimationFrameCallback',
     }
 
 _dart_to_idl_type_conversions = dict((v,k) for k, v in
                                      _idl_to_dart_type_conversions.iteritems())
 
+
+#
+# Identifiers that are used in the IDL than need to be treated specially because
+# *some* JavaScript processors forbid them as properties.
+#
+_javascript_keywords = ['delete', 'continue']
+
 #
 # Types with user-invocable constructors.  We do not have enough
 # information in IDL to create the signature.
 #
 # Each entry is of the form:
 #   type name: constructor parameters
 _constructable_types = {
     'AudioContext': '',
     'FileReader': '',
     'XMLHttpRequest': '',
@@ skipping 850 matching lines @@
     template = ''.join(open('template_wrapping_dom_externs.js').readlines())
     namespace = 'dom_externs'
     members = code.Emit(template, NAMESPACE=namespace)
 
     # TODO: Filter out externs that are known to the JavaScript back-end.  Some
     # of the known externs have useful declarations like @nosideeffects that
     # might improve back-end analysis.
 
     names = dict()  # maps name to (interface, kind)
     for (interface, name, kind) in self._wrapping_externs:
-      if name not in names:
-        names[name] = set()
-      names[name].add((interface, kind))
+      if name not in _javascript_keywords:
+        if name not in names:
+          names[name] = set()
+        names[name].add((interface, kind))
 
     for name in sorted(names.keys()):
       # Simply export the property name.
       extern = emitter.Format('$NAMESPACE.$NAME;',
                               NAMESPACE=namespace, NAME=name)
       members.EmitRaw(extern)
       # Add a big comment of all the attributes and operations contributing to
       # the export.
       filler = ' ' * (40 - 2 - len(extern))  # '2' for 2 spaces before comment.
       separator = filler + '  //'
@@ skipping 694 matching lines @@
             '  }\n'
             '}\n',
             CLASS=self._class_name,
             NAME=info.name,
             JSNAME1=js_name_1,
             JSNAME2=js_name_2,
             NATIVENAME=native_name,
             PARAMS=', '.join(['_this'] + arg_names),
             ARGS=', '.join(['_this.$dom'] + unwrap_args))
       else:
-        if info.js_name in ['delete', 'continue']:
+        if info.js_name in _javascript_keywords:
           access = "['%s']" % info.js_name
         else:
           access = ".%s" % info.js_name
         self._js_code.Emit(
             '\n'
             'function native_$(CLASS)_$(NATIVENAME)($PARAMS) {\n'
             '  try {\n'
             '    return __dom_wrap(_this.$dom$ACCESS($ARGS));\n'
             '  } catch (e) {\n'
             '    throw __dom_wrap_exception(e);\n'
@@ skipping 314 matching lines @@
     Arguments:
       info: An OperationInfo object.
     """
     # TODO(vsm): Handle overloads.
     self._members_emitter.Emit(
         '\n'
         '  $TYPE $NAME($ARGS) native;\n',
         TYPE=info.type_name,
         NAME=info.name,
         ARGS=info.arg_implementation_declaration)