media/tools/constrained_network_server/traffic_control_test.py - Issue 9127009: Constrained Network test does not fail fast under fatal conditions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/tools/constrained_network_server/traffic_control_test.py

Issue 9127009: Constrained Network test does not fail fast under fatal conditions. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Nits. Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/tools/constrained_network_server/cns.py ('K') | « media/tools/constrained_network_server/traffic_control.py ('k') | media/tools/constrained_network_server/traffic_control_unittest.py » ('j') | media/tools/constrained_network_server/traffic_control_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/tools/constrained_network_server/traffic_control_test.py

diff --git a/media/tools/constrained_network_server/traffic_control_test.py b/media/tools/constrained_network_server/traffic_control_test.py

index a84462f7a50f18f65e90d22392597ea8c8842af2..51398568e73b0a3d17d4751b942e80ae1742916b 100644

--- a/media/tools/constrained_network_server/traffic_control_test.py

+++ b/media/tools/constrained_network_server/traffic_control_test.py

@@ -75,10 +75,8 @@ class TrafficControlTests(unittest.TestCase):

'server_port': 33333,

'bandwidth': 2000

}

- # Convert Kbps to Kbit.

- rate = config['bandwidth'] * 8

class_detail = ('class htb 1:%x root prio 0 rate %dKbit ceil %dKbit' %

DaleCurtis 2012/01/06 23:19:42 s/Kbit/kbit/ ?

shadi 2012/01/07 04:56:19 They seem both to work. On 2012/01/06 23:19:42, Da

- (config['port'], rate, rate))

+ (config['port'], config['bandwidth'], config['bandwidth']))

# Add root qdisc.

traffic_control._AddRootQdisc(config['interface'])