Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 9125001: Adjust position recorded for call expressions. (Closed)

Created:
8 years, 11 months ago by Vyacheslav Egorov (Chromium)
Modified:
8 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Adjust position recorded for call expressions. For calls of the form ident(...) record position of the identifier as the position of the call. For other calls record positions of the opening parenthesis. This guarantees that for expressions of the form function(){}() call position will not intersect with positions recorded for function literal which is used by the debugger for scope chain resolution. R=kmillikin@chromium.org BUG=http://crbug.com/109195 TEST=test/mjsunit/regress/regress-109195.js Committed: http://code.google.com/p/v8/source/detail?r=10350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -2 lines) Patch
M src/parser.cc View 1 chunk +13 lines, -1 line 0 comments Download
M src/scopes.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-109195.js View 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
8 years, 11 months ago (2012-01-06 09:33:10 UTC) #1
Kevin Millikin (Chromium)
8 years, 11 months ago (2012-01-06 10:12:05 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698