Chromium Code Reviews Chromium Code Reviews
Issue 9124028:
separate about page into its own page (included in chrome://chrome) (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: chrome/browser/resources/about_page/about_page.html |
| diff --git a/chrome/browser/resources/options2/about_page.html b/chrome/browser/resources/about_page/about_page.html |
| similarity index 81% |
| rename from chrome/browser/resources/options2/about_page.html |
| rename to chrome/browser/resources/about_page/about_page.html |
| index 3ed27e1538579fefcead17d43812f505122c66b2..665efa234d7424026c24e607cec36703aa159700 100644 |
| --- a/chrome/browser/resources/options2/about_page.html |
| +++ b/chrome/browser/resources/about_page/about_page.html |
| @@ -1,4 +1,23 @@ |
| -<div id="aboutPage" class="page" hidden> |
| +<!DOCTYPE html> |
| +<html i18n-values="dir:textdirection;"> |
| +<head> |
| +<meta charset="utf-8"> |
| +<title i18n-content="pageTitle"></title> |
| + |
| +<link rel="stylesheet" href="chrome://resources/css/chrome_shared.css"> |
| +<link rel="stylesheet" href="chrome://resources/css/chrome_shared2.css"> |
| +<link rel="stylesheet" href="chrome://resources/css/open_sans.css"> |
| +<link rel="stylesheet" href="about_page.css"> |
| + |
| +<script src="chrome://resources/js/cr.js"></script> |
| +<script src="chrome://resources/js/util.js"></script> |
| + |
| +<script src="chrome://about-page-frame/about_page.js"></script> |
| +</head> |
| + |
| +<body> |
| + |
| +<div id="aboutPage" class="page"> |
| <h1 i18n-content="product"></h1> |
| <div id="aboutPageLessInfo"> |
| <section> |
| @@ -79,7 +98,7 @@ |
| </div> |
| <section> |
| <div> |
| - <div i18n-content="copyright"></div> |
| + <span i18n-content="copyright"></span> |
| <div> |
| <!-- Odd formatting to avoid unwanted spaces between elements. --> |
| <span i18n-content="license_content_0"> |
| @@ -117,3 +136,10 @@ |
| </div> |
| </section> |
| </div> |
| + |
| +</body> |
| + |
| +<script src="chrome://about-page-frame/strings.js"></script> |
| +<script src="chrome://resources/js/i18n_template.js"></script> |
| +<script src="chrome://resources/js/i18n_process.js"></script> |
|
Dan Beam
2012/01/10 19:38:24
Why are these outside the <body>?
|
| +</html> |
