Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9123029: Fix a couple of bugs in VM cctest running. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove unneeded re-registration of callbacks Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 2c9f591b06c773061df0256da3713fb4fb8f017f..f6d1ab21f9dd029fc5db52cc9b352614c24ba9b6 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -30,6 +30,10 @@ class CCTestListerIsolate extends Isolate {
line = stdoutStream.readLine();
}
};
+ p.errorHandler = (error) {
+ print("Failed to list tests: $runnerPath --list");
+ replyTo.send("");
+ };
p.exitHandler = (code) {
if (code < 0) {
print("Failed to list tests: $runnerPath --list");
@@ -40,6 +44,7 @@ class CCTestListerIsolate extends Isolate {
}
replyTo.send("");
};
+ port.close();
});
}
}
@@ -94,8 +99,6 @@ class CCTestSuite implements TestSuite {
configuration,
completeHandler,
expectations));
-
- receiveTestName.receive(testNameHandler);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698