Issue 9121055: Add a source to V8 proxy resolver-initiated DNS requests,

Issue 9121055: Add a source to V8 proxy resolver-initiated DNS requests, (Closed)

Created:
8 years, 11 months ago by mmenke

Modified:
8 years, 11 months ago

Reviewers:
eroman

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add a source to V8 proxy resolver-initiated DNS requests, when we have a source to add. R=eroman@chromium.org BUG=111641 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119517

Patch Set 2 : Reorder params to be consistent with HostResolver #

Patch Set 3 : Pass BoundNetLog around in unittest #

Total comments: 2

Patch Set 4 : Update year #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -26 lines)			Patch
M	net/proxy/proxy_resolver_js_bindings.cc	View	1	2 chunks	+14 lines, -3 lines	0 comments	Download
M	net/proxy/proxy_resolver_js_bindings_unittest.cc	View	1	4 chunks	+9 lines, -6 lines	0 comments	Download
M	net/proxy/proxy_resolver_perftest.cc	View	1 2 3	2 chunks	+3 lines, -2 lines	0 comments	Download
M	net/proxy/sync_host_resolver.h	View	1 2 3	3 chunks	+5 lines, -2 lines	0 comments	Download
M	net/proxy/sync_host_resolver_bridge.h	View	1 2 3	2 chunks	+3 lines, -2 lines	0 comments	Download
M	net/proxy/sync_host_resolver_bridge.cc	View	1 2 3	6 chunks	+14 lines, -9 lines	0 comments	Download
M	net/proxy/sync_host_resolver_bridge_unittest.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

eroman

lgtm http://codereview.chromium.org/9121055/diff/5003/net/proxy/sync_host_resolver.h File net/proxy/sync_host_resolver.h (right): http://codereview.chromium.org/9121055/diff/5003/net/proxy/sync_host_resolver.h#newcode1 net/proxy/sync_host_resolver.h:1: // Copyright (c) 2011 The Chromium Authors. All ...

8 years, 11 months ago (2012-01-27 20:22:53 UTC) #2

mmenke

Thanks. I'll check the other file, too, where I undoubtedly forgot about it as well.

8 years, 11 months ago (2012-01-27 20:25:02 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/9121055/19

8 years, 11 months ago (2012-01-27 20:27:20 UTC) #4

Change committed as 119517

Expand Messages | Collapse Messages