Added net logging to DownloadItem.

net/base/net_log_event_type_list.h

Index: net/base/net_log_event_type_list.h
diff --git a/net/base/net_log_event_type_list.h b/net/base/net_log_event_type_list.h
index 0bba60fa30927538febb61b76844ec20dc37279b..9d3903864de2ceaabf7d9798ee233c22b935b5c4 100644
--- a/net/base/net_log_event_type_list.h
+++ b/net/base/net_log_event_type_list.h
@@ -1451,6 +1451,105 @@ EVENT_TYPE(HTTP_PIPELINED_CONNECTION_RECEIVED_HEADERS)
 EVENT_TYPE(HTTP_PIPELINED_CONNECTION_STREAM_CLOSED)
 
 // ------------------------------------------------------------------------
+// Download start events.
+// ------------------------------------------------------------------------
+
+// This event is created when a download is started, and lets the URL request
+// event source know what download source it is using.
+//   {
+//     "source_dependency": <Source id of the download>,
+//   }
+EVENT_TYPE(DOWNLOAD_STARTED)
+
+// This event is created when a download is started, and lets the download
+// event source know what URL request it's associated with.
+//   {
+//     "source_dependency": <Source id of the request being waited on>,
+//   }
+EVENT_TYPE(DOWNLOAD_URL_REQUEST)
+
+// ------------------------------------------------------------------------
+// DownloadItem events.
+// ------------------------------------------------------------------------
+
+// This event lives for as long as a download item is active.
+// The BEGIN event occurs right after constrction, and has the following
+// parameters:
+//   {
+//     "type": <New/history/save page>,
+//     "id": <Download ID>,
+//     "original_url": <URL that initiated the download>,
+//     "final_url": <URL of the actual download file>,
+//     "intermediate_name": <The current file name>,
+//     "suggested_name": <The suggested final file name>,

[Randy Smith (Not in Mondays), 2012/02/05 23:49:15]

See previous comment on naming and commenting these values.  Asanka may be able
to help--I think he's been tracing this code.

[ahendrickson, 2012/02/07 00:16:19]

I've replaces "intermediate_name" and "suggested_name" with "file_name", and set
it depending on the type of download.

+//     "file": <Initial (temporary) file name>,
+//     "safety_state": <SAFE, DANGEROUS, DANGEROUS_BUT_VALIDATED>,
+//     "start_offset": <Where to start writing (defaults to 0)>,
+//   }
+// The END event will occur when the download is interrupted, canceled or
+// completed.
+EVENT_TYPE(DOWNLOAD_ITEM_ACTIVE)
+
+// This event is created when a download item has been checked by the
+// safe browsing system.
+//   {
+//     "safety_state": <SAFE, DANGEROUS, DANGEROUS_BUT_VALIDATED>,

[Randy Smith (Not in Mondays), 2012/02/05 23:49:15]

I would think if we're going to log safety state we'd also want to know about
danger type?

[Randy Smith (Not in Mondays), 2012/02/06 22:34:59]

Didn't see a response to this comment?

[ahendrickson, 2012/02/07 00:16:19]

Oh, sorry, I missed it.

Done.

+//   }
+EVENT_TYPE(DOWNLOAD_ITEM_SAFETY_STATE_UPDATED)
+
+// This event is created when a download item has been inserted into the
+// history database.
+//   {
+//     "db_handle": <The database handle for the item>,
+//   }
+EVENT_TYPE(DOWNLOAD_ITEM_IN_HISTORY)
+
+// This event is created when a download item is updated.
+//   {
+//     "bytes_so_far": <Number of bytes received>,
+//     "hash_state": <Current hash state, as a hex-encoded binary string>,
+//   }
+EVENT_TYPE(DOWNLOAD_ITEM_UPDATED)
+
+// This event is created when a download item is renamed.
+//   {
+//     "old_filename": <Old file name>,
+//     "new_filename": <New file name>,
+//   }
+EVENT_TYPE(DOWNLOAD_ITEM_RENAMED)
+
+// This event is created when a download item is interrupted.
+//   {
+//     "reason": <The reason for the interruption>,
+//     "bytes_so_far": <Number of bytes received>,
+//     "hash_state": <Current hash state, as a hex-encoded binary string>,
+//   }
+EVENT_TYPE(DOWNLOAD_ITEM_INTERRUPTED)
+
+// This event is created when a download item is resumed.
+//   {
+//     "user_initiated": <True if user initiated resume>,
+//     "reason": <The reason for the interruption>,
+//     "bytes_so_far": <Number of bytes received>,
+//     "hash_state": <Current hash state, as a hex-encoded binary string>,
+//   }
+EVENT_TYPE(DOWNLOAD_ITEM_RESUMED)
+
+// This event is created when a download item is finished.
+//   {
+//     "bytes_so_far": <Number of bytes received>,
+//     "final_hash": <Final hash, as a hex-encoded binary string>,
+//   }
+EVENT_TYPE(DOWNLOAD_ITEM_FINISHED)
+
+// This event is created when a download item is canceled.
+//   {
+//     "bytes_so_far": <Number of bytes received>,
+//     "hash_state": <Current hash state, as a hex-encoded binary string>,
+//   }
+EVENT_TYPE(DOWNLOAD_ITEM_CANCELED)
+
+// ------------------------------------------------------------------------
 // DownloadFile events.
 // ------------------------------------------------------------------------