Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2797)

Unified Diff: chrome/browser/resources/net_internals/source_entry.js

Issue 9121053: Added net logging to DownloadItem. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merged with parent. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/net_internals/source_entry.js
diff --git a/chrome/browser/resources/net_internals/source_entry.js b/chrome/browser/resources/net_internals/source_entry.js
index 7476f647bbd25885a89a0d498e0fea3321e59753..0cb526e203726d2c7a5929a1d28c452e90878a0d 100644
--- a/chrome/browser/resources/net_internals/source_entry.js
+++ b/chrome/browser/resources/net_internals/source_entry.js
@@ -140,6 +140,9 @@ var SourceEntry = (function() {
case LogEventType.DOWNLOAD_FILE_OPENED:
this.description_ = e.params.file_name;
break;
+ case LogEventType.DOWNLOAD_ITEM_ACTIVE:
+ this.description_ = e.params.intermediate_name;
+ break;
}
break;
case LogSourceType.FILESTREAM:
@@ -183,6 +186,10 @@ var SourceEntry = (function() {
e = this.findLogEntryByType_(LogEventType.DOWNLOAD_FILE_OPENED);
if (e != undefined)
return e;
+ // History items are never opened, so use the activation info
+ e = this.findLogEntryByType_(LogEventType.DOWNLOAD_ITEM_ACTIVE);
Randy Smith (Not in Mondays) 2012/02/03 18:23:37 Why aren't we using the DOWNLOAD_ITEM_ACTIVE in pr
ahendrickson 2012/02/04 05:24:04 This information is used to determine what to show
+ if (e != undefined)
+ return e;
}
if (this.entries_.length >= 2) {
if (this.entries_[0].type == LogEventType.REQUEST_ALIVE ||

Powered by Google App Engine
This is Rietveld 408576698