Added net logging to DownloadItem.

chrome/browser/net/passive_log_collector.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/passive_log_collector.h"
 
 #include <algorithm>
 
 #include "base/compiler_specific.h"
 #include "base/string_util.h"
@@ skipping 851 matching lines @@
 PassiveLogCollector::
     DowloadTracker::DowloadTracker()
         : SourceTracker(kMaxNumSources, kMaxGraveyardSize, NULL) {
 }
 
 PassiveLogCollector::SourceTracker::Action
 PassiveLogCollector::DowloadTracker::DoAddEntry(
     const ChromeNetLog::Entry& entry,
     SourceInfo* out_info) {
   AddEntryToSourceInfo(entry, out_info);
-  if (entry.type == net::NetLog::TYPE_DOWNLOAD_FILE_OPENED &&
+  if (entry.type == net::NetLog::TYPE_DOWNLOAD_ITEM_ACTIVE &&

[Randy Smith (Not in Mondays), 2012/02/03 18:23:37]

Sorry, my lack of knowledge of netlog, but what is the purpose of this routine? 
If it's to close off dangling begin events, aren't there other begin events we
need to close off?

[mmenke, 2012/02/03 18:27:54]

Two purposes:  To avoid keeping spammy events around and to know when we've seen
a source's last close event, so we know when we can clean it up.

       entry.phase == net::NetLog::PHASE_END) {
     return ACTION_MOVE_TO_GRAVEYARD;
   }
   return ACTION_NONE;
 }
 
 //----------------------------------------------------------------------------
 // FileStreamTracker
 //----------------------------------------------------------------------------
 
@@ skipping 12 matching lines @@
 PassiveLogCollector::FileStreamTracker::DoAddEntry(
     const ChromeNetLog::Entry& entry,
     SourceInfo* out_info) {
   AddEntryToSourceInfo(entry, out_info);
   if (entry.type == net::NetLog::TYPE_FILE_STREAM_ALIVE &&
       entry.phase == net::NetLog::PHASE_END) {
     return ACTION_MOVE_TO_GRAVEYARD;
   }
   return ACTION_NONE;
 }