Cleanup in ProcessSingleton.

base/process_util_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/process_util.h"
 
 #include <fcntl.h>
 #include <io.h>
 #include <windows.h>
 #include <userenv.h>
@@ skipping 156 matching lines @@
 }  // namespace
 
 ProcessId GetCurrentProcId() {
   return ::GetCurrentProcessId();
 }
 
 ProcessHandle GetCurrentProcessHandle() {
   return ::GetCurrentProcess();
 }
 
+HMODULE GetModuleFromAddress(void* address) {
+  MEMORY_BASIC_INFORMATION info = {0};

[Evan Martin, 2012/01/27 16:17:41]

FWIW, you can do
  MEMORY_BASIC_INFORMATION info = {};
to initialize a struct to all-zeroes, even when the first field is not
initializable from an integer.  (I only learned this recently and am compelled
to share it!)

[Jói, 2012/02/10 09:11:57]

Cool, nice tip :)

+  ::VirtualQuery(address, &info, sizeof(info));

[Evan Martin, 2012/01/27 16:17:41]

Shouldn't we be checking the return value?  What if the address is invalid, for
example?

[Jói, 2012/02/10 09:11:57]

It is now checked, for the new API that Robert suggested.

+  return reinterpret_cast<HMODULE>(info.AllocationBase);

[robertshield, 2012/01/27 16:26:45]

I know you took this from CF, so I almost feel bad commenting here.
Nevertheless, fwiw, you can also call GetModuleHandleEx with
GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS.

[cpu_(ooo_6.6-7.5), 2012/01/27 19:31:50]

Yes please use Robert's method.

On 2012/01/27 16:26:45, robertshield wrote:

+}
+
 bool OpenProcessHandle(ProcessId pid, ProcessHandle* handle) {
   // We try to limit privileges granted to the handle. If you need this
   // for test code, consider using OpenPrivilegedProcessHandle instead of
   // adding more privileges here.
   ProcessHandle result = OpenProcess(PROCESS_DUP_HANDLE | PROCESS_TERMINATE,
                                      FALSE, pid);
 
   if (result == INVALID_HANDLE_VALUE)
     return false;
 
@@ skipping 805 matching lines @@
 
   PERFORMANCE_INFORMATION info;
   if (!InternalGetPerformanceInfo(&info, sizeof(info))) {
     DLOG(ERROR) << "Failed to fetch internal performance info.";
     return 0;
   }
   return (info.CommitTotal * system_info.dwPageSize) / 1024;
 }
 
 }  // namespace base