Make DFAKE_MUTEX a typedef when using NDEBUG, so that pedantic compilers don't warn about an extra …

Make DFAKE_MUTEX a typedef when using NDEBUG, so that pedantic compilers don't warn about an extra ; in a class definition

BUG=111583
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119574

[Ryan Sleevi, 2012-01-27 03:03:08]

First one to stamp wins? Who doesn't love a little pre-processor magic.

This is blocking the NaCL team from rolling forward to a more recent Chromium
DEPS, so there's a desire to fix this. I'm guessing the NaCl compiler chain is
much more pedantic than our existing compilers are are on this matter.

[pdox, 2012-01-27 05:42:43]

thanks for handling this!

[brettw, 2012-01-27 22:33:32]

lgtm

http://codereview.chromium.org/9121034/diff/1/base/threading/thread_collision...
File base/threading/thread_collision_warner.h (right):

http://codereview.chromium.org/9121034/diff/1/base/threading/thread_collision...
base/threading/thread_collision_warner.h:122: #define DFAKE_MUTEX(obj) typedef
void __InternalFakeMutexType##obj
Probably shouldn't use __, since isn't that supposed to be reserved by the
compiler? Probably InternalFakeMutex##obj is fine.

[commit-bot: I haz the power, 2012-01-27 23:37:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/9121034/3

[commit-bot: I haz the power, 2012-01-28 03:09:55]

Change committed as 119574